Re: [PATCH] bash-completions: add --[no-]graph-indent

["Pablo Sabater" <pabloosabaterr@gmail.com>]

[Cc'd Toon because of the mention]

On Tue Oct 13, 2026 at 8:50 PM WEST, Mirko Faina wrote:
> Add missing completion for "git log --graph-indent" and "git log
> --no-graph-indent".
>
> Signed-off-by: Mirko Faina <mroik@delayed.space>
> ---
>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index c3a49e2e22..2348a3cfb9 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2298,6 +2298,7 @@ __git_log_common_options="
>  	--right-only --show-linear-break
>  	--show-notes-by-default --show-pulls
>  	--since-as-filter --single-worktree
> +	--graph-indent --no-graph-indent

Thanks for Cc'ing.

I didn't know about this so I completely forgot to add it, however from
what I read, this is the __git_log_common_options and I'm not sure if
this is a "common" opt, as I don't even see --graph here.

I searched where --graph is, and it's here:

l 2383-2409 'git-completion.bash'

	__gitcomp "
[more opts]
		--graph
[more opts]
		$merge
		$__git_diff_common_options
		"
	return
	;;

I think it would fit better here (not sure, I just quickly skimmed the
file).

Also, I missed this for the --graph-lane-limit option so maybe it should
be added too?

My main doubt is, both these options proposed (yours and
--graph-lane-limit) are --graph dependent, which means if someone
autocompletes them but doesn't use --graph, they will get an error
saying that --graph is needed. I'd say we do what other --graph
dependent options do, but AFAIK these two are the only ones.

From Toon's Git Merge talk, more options for --graph option will be
developed so we should maybe think about how to do it in a way that 
doesn't autocomplete if it's going to error? (maybe that does exist,
given the multiple options that depend on other options)

>  "
>  # Options that go well for log and gitk (not shortlog)
>  __git_log_gitk_options="
>
> base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd

Thanks,
Pablo