All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: "Richard Purdie" <rpurdie@rpsys.net>,
	<bitbake-devel@lists.openembedded.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [bitbake-devel] [PATCH RFC 3/3] runqueue: Hand each covered task's log to a single setscene task
Date: Fri, 30 Oct 2026 16:54:21 +0100	[thread overview]
Message-ID: <DMIAM5878KKF.2UFLZ25JCPACZ@bootlin.com> (raw)
In-Reply-To: <dbd7b348c19f311707890f325bf643d3b9b33cee.camel@rpsys.net>

On Sun Oct 25, 2026 at 3:20 PM CET, Richard Purdie wrote:
> On Sat, 2026-10-24 at 14:33 +0200, Mathieu Dubois-Briand via lists.openembedded.org wrote:
>> When a setscene task starts, hand it the covered tasks of the same recipe
>> which were not yet handed to another setscene task, and pass their names
>> to the task through BB_SETSCENE_REPLAY_TASKS. Several setscene tasks can
>> cover the same task (e.g. do_populate_sysroot and do_package both cover
>> do_compile), so this lets metadata replay the log of each covered task
>> exactly once when restoring it from the sstate cache.
>> 
>> AI-Generated: Uses opencode (DeepSeek V4 Flash)
>> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
>> ---
>>  bin/bitbake-worker | 1 +
>>  lib/bb/runqueue.py | 9 +++++++++
>>  2 files changed, 10 insertions(+)
>
> This is a very specific piece of API, specifically tailored to what
> this particular task entails.
>

Just to make sure I fully understand this: I should rather try to rely
more on existing API or introduce something a bit more generic. Is that
right?

> I'm a bit worried that it still doesn't cover everything it should, for
> example a warning from another recipe that is only covered by a given
> sstate task and nothing else.

Indeed. Knowing we have to replay these logs should be easy, but
accessing these logs in the first place might be a bit tricky. I will
have to experiment a bit and understand what is possible.

>
> You can pobably calculate it from BB_TASKDEPDATA already too, if you
> know which tasks are sstate, which I think we know.
>
> There is also the potential for multiple log output from these covered
> tasks, e.g. do_package and do_populate_sysroot both 'cover' on
> do_install so a warning from do_install will be shown by both tasks at
> setscene time.
>

This should not happen with the current code. But I will have to be
careful when covering tasks from another recipe.

In your example, only one of the two tasks should be assigned with the
logs of do_install, either do_package or do_populate_sysroot, but not
both. This is the point of the sq_replay_assigned set here.

Also, it should be covered by my tests on the oe-core side.

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2026-10-30 15:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 12:33 [PATCH RFC 0/3] Preparatory work for sstate cache log replay Mathieu Dubois-Briand
2026-10-24 12:33 ` [PATCH RFC 1/3] utils: Extend LogCatcher to record raw messages and levels Mathieu Dubois-Briand
2026-10-24 12:33 ` [PATCH RFC 2/3] build: Attach a log catcher to tasks and save their records Mathieu Dubois-Briand
2026-10-25 14:15   ` [bitbake-devel] " Richard Purdie
2026-10-30 15:56     ` Mathieu Dubois-Briand
2026-10-24 12:33 ` [PATCH RFC 3/3] runqueue: Hand each covered task's log to a single setscene task Mathieu Dubois-Briand
2026-10-25 14:20   ` [bitbake-devel] " Richard Purdie
2026-10-30 15:54     ` Mathieu Dubois-Briand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMIAM5878KKF.2UFLZ25JCPACZ@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=rpurdie@rpsys.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.