From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52C0B606C599 for ; Tue, 3 Nov 2026 10:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Lj60IoEy Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0288710E4A4; Tue, 3 Nov 2026 10:57:10 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0762210F4F0 for ; Tue, 3 Nov 2026 10:56:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793703372; x=1825239372; h=content-transfer-encoding:date:message-id:to:cc:subject: from:references:in-reply-to:mime-version; bh=hxhUDmGMYK/ilAY/N6NJnRVkWhY9gDUYyOG2iStVpEs=; b=Lj60IoEyfL19yeJTVINrHMJKJ3rgT0xiEmcapwAUXHi2DYCmtzcN5o1T dK2y0MmbSR76TYarseSle1evMEaW308EPHlJy4IBit3zy4AotrkAoPB1l myblObBV3d8nRH7Xg5ATUPJQIDYTCCm0VRLCVbNv0nDMRyr6sttdHv9Hh 9Dk0tpqVjnZ/Z/inb4zb5e9VJWZEUc1EZkHgj9hdJT5dlXvmmVEWXP4Xj fp6a0jlFNqVtQZkbYi1Tn822yMrnmxepAunAs/r54V+Z5LIeQlysyhJ9W cNUmtt3/UKKbtrKXd6l0odcw2BJZGjAQegeDxmcGMeIIwEvbjFz6U26u6 A==; X-CSE-ConnectionGUID: qzWP+SjFS9aVkRMjwfFi7Q== X-CSE-MsgGUID: D2bbOjuRQr27qPpncYIWXQ== X-IronPort-AV: E=McAfee;i="6800,10657,11954"; a="2312870" X-IronPort-AV: E=Sophos;i="6.27,193,1787036400"; d="scan'208";a="2312870" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2026 02:56:11 -0800 X-CSE-ConnectionGUID: bwOjuc6gSNeF8F0GYdCnFw== X-CSE-MsgGUID: 8xzEWt9hSK+mFULMVz9TNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,193,1787036400"; d="scan'208";a="6299712" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2026 02:56:10 -0800 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56; Tue, 3 Nov 2026 02:56:10 -0800 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56 via Frontend Transport; Tue, 3 Nov 2026 02:56:10 -0800 Received: from BYAPR05CU005.outbound.protection.outlook.com (52.101.85.36) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56; Tue, 3 Nov 2026 02:56:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gb+5Kb0b9O8Fg6qOgI+PvbUjLjpVNZXdQDBMZNr8dwEi80K5RfecB2pRW0kF8HC6b9tDrFpZ+2lMLlega7fjFtrds7/p5aowxDLqB4GPrbroPT/WgwqzUp33cUiMgj6XCA9hU3pUGrD1M3zpMD/XqkcZsH1MzzLKvPvYa1znpDKnrtU4Lz0VEwyHtY4eL86zLuR1FtkiM/SJt5gMY3kPZL0+5FxEbiZyGF8h5CUrh3Io/txHWMeDFfF1S6tBsMyyRutNg5/ukHtAulW98C4Di8o28ZFdTAHz5ur0Ghe59bNUo/NysCz/70u8uKNVWISOcWMoNtl6LBFvJeTdByfQtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hxhUDmGMYK/ilAY/N6NJnRVkWhY9gDUYyOG2iStVpEs=; b=dPZkaafB6wGuo6DQHodESWe+Q3Hjp29hBhvLp/e/GddkHGegGu584UmknSI4DDkes8ljOLW9VMyraQJ9OQzdky021wrZvG8pTh2GWQyT2MBuSH8LlvpBaWaJD76gefQlV+FsmMo/Iq6RS32gxIof96H1QAvAwz0FeyTsrvgWFD4GIPu+3N42L3ICPw6mSCaoAVJA9tBd8bXkW0xR45VpcHCo0DufqZfo89V+KeS5JZKtDMXJgKcs0BTKqWNf+rxhlkN94GPCl8rw6spganhkBy0Z18CS8OzLj8wfILfN1/Qs6WsMI+l97L5sc6KuvzsdEn1EF+mN47//fZvSJn8WPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS4PR11MB134916.namprd11.prod.outlook.com (2603:10b6:8:4f0::21) by MN0PR11MB5963.namprd11.prod.outlook.com (2603:10b6:208:372::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 10:56:07 +0000 Received: from DS4PR11MB134916.namprd11.prod.outlook.com ([fe80::87f6:b354:5770:3ad4]) by DS4PR11MB134916.namprd11.prod.outlook.com ([fe80::87f6:b354:5770:3ad4%5]) with mapi id 15.21.0569.011; Tue, 3 Nov 2026 10:56:06 +0000 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Date: Tue, 3 Nov 2026 11:56:01 +0100 Message-ID: To: David Francis , CC: , Vitaly Prosyak , Kamil Konieczny , Sebastian Brzezinka , Christian Konig , Simona Vetter , Alex Deucher Subject: Re: [PATCH] tests/intel: Add edge case and race condition tests for GEM_CHANGE_HANDLE From: Sebastian Brzezinka X-Mailer: aerc 0.22.0 References: <20261007141209.2928162-1-David.Francis@amd.com> In-Reply-To: <20261007141209.2928162-1-David.Francis@amd.com> X-ClientProxiedBy: WA1PEPF00005B9D.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d8::635) To DS4PR11MB134916.namprd11.prod.outlook.com (2603:10b6:8:4f0::21) X-Archived-By: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS4PR11MB134916:EE_|MN0PR11MB5963:EE_ X-MS-Office365-Filtering-Correlation-Id: 2a1f1f85-de48-4965-5407-08df39990fb8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|23010399003|6133799003|10067099003|22082099003|18002099003|261102123227099003|11063799006|261022105027099003|261026140227099003|261009223027099003|261021135927099003|261021121427099003|261026121527099003|261028144727099003|56012099006|261102130727099003; X-Microsoft-Antispam-Message-Info: FYR9JAN26/FUfcpOGzwA97kUgjqgpc2JB2BErPl1RTsuhkKl/bRWiEkwbgjWfXEIjqFv+EYM3uEJ2QcNts+HyjH+piNJPu50LQiRIs1WqKLVA3AkwwLzluh7PASmWvYTuMXoQ9bsj2cUoQyEA/nmJ3uPIUtuxpe3l7wdB+PhVV+ba+6jCYJ0NdWxbeUdYiaCtQgvFtJrDf4rGd3v4/9DHQsav7GJoUuomrD1I5e3f6WHrjMBOn/cmzEgZ3m8iGMWmI7MGHR5+OapWx7orsaXYtoCRb3BGLhnFhL+iowQy+QexVsSBDVBGZIurI4rqKzjMTWs6/kZsCKXbFiXEYq556zdoAX5wab1v2Gs9gTU0l/zIiAIguIRP2QZySDMkZr+IggpUKjNRy0atrHk3L+Kg390c8AFGTMTiNEy4dqgeEICzwI0lRQ8r4fwaSVXZpswSRuaOBCmvBDYIjyTW0H6cGL45lTFt4vVkoE1BTUjGqT0Pl04ZUTf0animEk67ql8YN6yWQZcLU1EtYXZHUJPbj19UaRIpQLk5Cdzg01BkRJNmhLiG0LgkYQcwqNKW0DvYU6yYYWY+GUcXsoqNxm+946CvjA5CJymDIbOQWYDGCNEnnCSUdjhJjAq3sNqovVn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS4PR11MB134916.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(23010399003)(6133799003)(10067099003)(22082099003)(18002099003)(261102123227099003)(11063799006)(261022105027099003)(261026140227099003)(261009223027099003)(261021135927099003)(261021121427099003)(261026121527099003)(261028144727099003)(56012099006)(261102130727099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjAyK0hIOU56OHhGZmNlNTY3elByOE9wS3pwMHlHU28waUdnazlFTnc5NzVp?= =?utf-8?B?WTJ6WUprU0lLTlpnU3JpSGxzc1NiNVZpcEtXZzVnSXp3MzEyQjBiYUNxRC9i?= =?utf-8?B?ZlhyUGVIZ25Zbi9NcnhBV2UwTFcyNHF2RlRnUjRhUHdEeVp1T2xoRUd2T0Zx?= =?utf-8?B?QW0wb0tlUVhmUGg0SjhBYXFOTkJ3MDNqK21VckVkY2dPQjlzcGl0akxiTjlj?= =?utf-8?B?VnMwbENxYVQvcmIxRVlBNlQ1T1NqbEhQS2dYVElocDRqSVRZazYzUUxnWHJP?= =?utf-8?B?MU5WRklGQzJLL01aazVaRE5kVEVwRWlHMDdoaDA4ZTVGY254T2h0QUlnc1A3?= =?utf-8?B?MGZ0alR2VklKRktXZUsxZHJTSkZvR2dyWFBXTTVIRmRSZ09BMWc3eCt5RG9K?= =?utf-8?B?cTRUOEE3NWxMT0d5MGNNbGhQRDFjVTRkcjdkTVl3WERMTWZIU3RtdlYwVUtD?= =?utf-8?B?b0QyUVUrWmE4d1djbG5QYTJkODRlK1BzN0pqb0xldDNmYzR4bFBvamxjTUQy?= =?utf-8?B?MVFZSGM5RXcydjVCazQyZnBITmNtakRVUHBaN1VLUEI3QVNsem1qL2M3eVhS?= =?utf-8?B?STJDT2xtQUdCZEx5QVdZRW0rSWFGRnVHU2lLdEtrQmxvTi9QcVNlWVRxN2hI?= =?utf-8?B?TWNidkd0S0ZpelJ2aThiSTA2OWJyTjRaaGEzdVdhR0pxb3hSQzR5Wm9xczRC?= =?utf-8?B?NWFRRm9LUUhjYTJKTlAwd3MxWjl4TUpxb04yWTUweU5yWEovNFFZOXlOTjhM?= =?utf-8?B?YWpWRC9BeHFIMnRVRXRNZ21HM1lvbFVKODl1LytVWDVMay96NXRxLzhSQnFz?= =?utf-8?B?R2dFOXpkVVJRMStxQ0dLbFBPc3NzLzE0VWdyckZCa0wxbld4bjFNYzdpTU9R?= =?utf-8?B?SjBrMFlvYmM0NWlkdFpVWVVQazNua1ErR1FRQ1FhSGZKUjdTWEprR0czS3Jz?= =?utf-8?B?Wk4xaUhobnVjaDZIZTNNM3VvUlU5UDg5WkdTc3E4NStRSHBHRlhNbGxsOXVM?= =?utf-8?B?NUc4SUpxTnpBeWlTc2NBUlhuSDRDblhkZFVWTG8ybHk1VllOYURSR3lSZ3Jy?= =?utf-8?B?azV1NG1CaXVVTjc2ejJiZGEzODZBYTg1Y2QvMTNjOWJsaEpaMVI1VERyVHh3?= =?utf-8?B?Q0JGcHdzcGdsY04yUFZaQkVIUCtCYTdlcjM4N1p6azhQVkpmSVVGL2J4eERD?= =?utf-8?B?elRJYzhMcTg0SEdqTmxLUWlINWx5dVpzYmF5bVlVbjhyR0J2TzAwNGdOdXc4?= =?utf-8?B?d1N6YXM2ejVyZWFNN3FzU3VFL2syQTNuekZXUnFLSUx5OENnazkyaE5iK3dS?= =?utf-8?B?aEg3TDJwenpMajV5Ylh2Z3doOTIvaXgyeFRjVzdlNHcyRXk1cmZwUFdydXNj?= =?utf-8?B?TDQ5aW5WWVFGWERBVk8vWnR3MVlnYXU1a2U3RFVTcndRVHQwVjRqZ003bTJt?= =?utf-8?B?OE82TCt2WnRNQ3Myd3gvQjJFRkd5ZTB3bmp1aHJLM3BTS2FOai9nQ0k5N2JO?= =?utf-8?B?Y3JaaGR6SERFd29QenJCeC9KRDh2Wjd1ajhVUW5nVjRIeVhkRUlGbi81Snk4?= =?utf-8?B?cDdnSlhKNVdYU3ZMR0FFU3JpZlJMdVZteFVHY1JSRVRXRXJVb1lXWW9RZ01r?= =?utf-8?B?SGpWTTZGOWlWQ0p2WEZnT0FGL1J6OGdSOXFyY3lKZXFKaXBHQWUyaXltZmNs?= =?utf-8?B?S1VkaU92ZWtOQXdMWHZBbFpUbXdNY1NsTlJHK2pMbGpMN3dCSmRkQ1h2S0hB?= =?utf-8?B?bFdGKzZwYkFWMmdYV1RMSGVkTmx2ZWprc1kyTTE1TU9wQmNJdENwQTU3TnRH?= =?utf-8?B?dTZOY2tiSFRULzZsbTBIb3hzKy9DVUFOTFloVS9YUy9RWlVCbm1PZzF4R1Yz?= =?utf-8?B?b3RYSVEreVBldS9kK3h5SS9lRm5NNVdKU3NrYWtzeW9LUitwZUFCYitmdUZm?= =?utf-8?B?YmxGU05nR3VwUnVWZ3dkU0Z5Zm0rb0ZaOGh3UFdWWDBzeWlDSHJmQWtla0Fs?= =?utf-8?B?RU42UTJNaXZON1BOWUQweWVxVkxxUGlxUklrWGwxWTAzc2p4MVgxSVd1SE1k?= =?utf-8?B?SG9iVTZZOUdHbUtHekFNLzBqSm1Qck5GUHc2NWl4YlJnc3ZlbzdvSENsNnp2?= =?utf-8?B?blh2WmhWRjFuUjVBM0MrZHJuWjZ5ZW5TSEhKcG5mMVdCMlhIZHkyVWZiYkdl?= =?utf-8?B?b24rRzJhWkxLTDAxNWZLdTZ1aktISFR3ZUoyMUFybDQyWWpPQUpjYjdCT0xM?= =?utf-8?B?VEVaRWwzUFdPZDRwRTgxcGJUV2xZb2QvRmVraGdNYURDM1g4RWYxTjdxWVNN?= =?utf-8?B?Z1k0TlVwdEpDcm1HYlZjVWJuMGRVOTBXUWI1UjY3MHNBdGg3RlhhUjMvVjlj?= =?utf-8?Q?kdOkb3C8vNUOyVXQ=3D?= X-Exchange-RoutingPolicyChecked: mUT9U9CDijYoIkF8Dtx3HsMCYqHqD9+Kc9NGaiZPgqZBgx3wn8PP9oeXLF6BX/YoONgNpCJmtdRCmWM4T1Hr8EW52iMw2+M6pc3TmNDCDbyGNLETbAzpv3VKRT4OshOcBe31h+B4Ge6Mx2nECflm0lansZA7ZR+WsejbbvzRnwdSXNolSs8cskAwXdDpOBBPY1NBcDzWTcuLGB00E2QaPI7p9Pc14cKqeTz3T5bW+YSD+SLdRxquhAtBPpEzIirSRbFNq2gr97cHY3BagfZIcHLj8aQnlkVkFrbJ/8O+Kjy81PjpMaKZgXnFybBCH6qDkB7BBJQ+nUjL4btdXdPKTg== X-MS-Exchange-CrossTenant-Network-Message-Id: 2a1f1f85-de48-4965-5407-08df39990fb8 X-MS-Exchange-CrossTenant-AuthSource: DS4PR11MB134916.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 10:56:06.7429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0hUtoWZ1FmcprvbXUEdusDr7D6rPGUkcaZswH9UnnM+PCceUOrw22cg13cfpRzxRGOewWa6fuCpfEpQSbDDiqTNcR9nLrmrZiAnB+fCBLHw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5963 X-OriginatorOrg: intel.com X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "igt-dev" X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Hi David, On Wed Oct 7, 2026 at 4:12 PM CEST, David Francis wrote: > From: Vitaly Prosyak > > Add a GPU-agnostic GEM_CHANGE_HANDLE tests. These test for basic > functionality, edge cases, and race conditions of this ioctl against > itself, gem close, gem create, and prime import and export. > > GEM_CHANGE_HANDLE is currently wired to drm_invalid_op in DRM core. This = IGT > coverage is a prerequisite for validating the eventual kernel-side ioctl > implementation and makes fixing its security bugs safer. > > Cc: Kamil Konieczny > Cc: Sebastian Brzezinka > Cc: Christian Konig > Cc: Simona Vetter > Cc: Alex Deucher > Signed-off-by: Vitaly Prosyak > Signed-off-by: David Francis > --- To me these tests look reasonable, but we need to make sure we don't pollute CI with failures. GEM_CHANGE_HANDLE is still=C2=A0drm_invalid_op=C2= =A0 in DRM core, so on current kernels every subtest fails. The best path would be to merge the kernel side first. But since these tests are a prerequisite for the kernel patches, we need to work around that somehow. Until the kernel part lands, the tests could skip when the ioctl returns -EINVAL or -ENOTTY. Could you add that in the next revision? For the contribution process, please take a look at the guide: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/CONTRIBUTING= .md In short, patches are reviewed on the igt-dev mailing list, not through GitLab merge requests. It would be nice to get an ack from one of the maintainers (Kamil is Cc'd) before this is merged. --=20 Best regards, Sebastian