All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
To: "Francis, David" <David.Francis@amd.com>,
	Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Prosyak, Vitaly" <Vitaly.Prosyak@amd.com>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	Simona Vetter <simona@ffwll.ch>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>
Subject: Re: [PATCH v2] tests/intel: Add edge case and race condition tests for GEM_CHANGE_HANDLE
Date: Tue, 3 Nov 2026 11:57:50 +0100	[thread overview]
Message-ID: <DMLITAGRZ0FB.174JIVJFEEEFZ@intel.com> (raw)
In-Reply-To: <CHAPR12MB999247A855D151A61B5801D113EF6A2@CHAPR12MB999247.namprd12.prod.outlook.com>

Hi David,

On Mon Nov 2, 2026 at 4:10 PM CET, David Francis wrote:
> Thanks for running the tests. I'm new to the IGT development process.
> Are these tests good to merge or do they require additional review?
> I have this change on a gitlab branch
> (https://gitlab.freedesktop.org/fdavid-amd/igt-gpu-tools/-/tree/gem-change-handle-tests)
> What is the procedure for getting a change merged?
>
> Thanks,
> David Francis
>
To me these tests look reasonable, but we need to make sure we don't
pollute CI with failures. GEM_CHANGE_HANDLE is still drm_invalid_op 
in DRM core, so on current kernels every subtest fails.

The best path would be to merge the kernel side first. But since these
tests are a prerequisite for the kernel patches, we need to work around
that somehow. Until the kernel part lands, the tests could skip when the
ioctl returns -EINVAL or -ENOTTY. Could you add that in the next revision?

For the contribution process, please take a look at the guide:
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/CONTRIBUTING.md

In short, patches are reviewed on the igt-dev mailing list, not through
GitLab merge requests. It would be nice to get an ack from one of the
maintainers (Kamil is Cc'd) before this is merged.


-- 
Best regards,
Sebastian


  reply	other threads:[~2026-11-03 10:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 14:53 Tests for GEM_CHANGE_HANDLE (v2) David Francis
2026-10-15 14:53 ` [PATCH v2] tests/intel: Add edge case and race condition tests for GEM_CHANGE_HANDLE David Francis
2026-10-29 10:42   ` Sebastian Brzezinka
2026-11-02 15:10     ` Francis, David
2026-11-03 10:57       ` Sebastian Brzezinka [this message]
2026-11-03 19:24         ` Francis, David
2026-10-15 19:19 ` ✗ i915.CI.BAT: failure for tests/intel: Add edge case and race condition tests for GEM_CHANGE_HANDLE (rev4) Patchwork
2026-10-15 20:46 ` ✗ Xe.CI.BAT: " Patchwork
2026-10-16  6:37 ` ✓ Xe.CI.FULL: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMLITAGRZ0FB.174JIVJFEEEFZ@intel.com \
    --to=sebastian.brzezinka@intel.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=David.Francis@amd.com \
    --cc=Vitaly.Prosyak@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.