Re: [OE-core] [PATCH v11 1/4] libtoml1: fix building tests with gcc 16

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Tue Nov 3, 2026 at 3:59 PM CET, Adam Duskett via openembedded-core wrote:
> GCC 16 warns that the format may be used uninitialized when a value is
> assigned a different type, for example:
>
>   toml::value v(true);
>   v = std::chrono::hours(1);
>
> The warning is a false positive, but the tests build with -Werror, so
> the build fails.
>
> Every operator= copied the old format out of the union behind a type
> check that GCC could not see through, so it flagged a possible read of
> an inactive member.
>
> Add a small helper that keeps the format when the type is unchanged and
> uses the default format otherwise, so the old format is never copied.
> The convenience overloads now convert their argument and forward to the
> main ones, removing a lot of duplicated code.
>
> Fixes:
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/40/builds/4814
>
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---

Hi Adam,

Thanks for the new version.

We can see three selftest failures on the autobuilder:

2026-11-03 21:45:31,569 - oe-selftest - INFO - buildoptions.ImageOptionsTests.test_incremental_image_generation (subunit.RemotedTestCase)
2026-11-03 21:45:31,580 - oe-selftest - INFO -  ... FAIL
...
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/buildoptions.py", line 32, in test_incremental_image_generation
    self.assertTrue(incremental_created, msg = "Match failed in:\n%s" % log_data_created)
  File "/usr/lib/python3.12/unittest/case.py", line 727, in assertTrue
    raise self.failureException(msg)
AssertionError: None is not true : Match failed in:
...
ERROR: core-image-minimal-1.0-r0 do_rootfs: Postinstall scriptlets of ['postinst-rootfs-failing-0:1.0-r0.noarch'] have failed. If the intention is to defer them to first boot,
then please place them into pkg_postinst_ontarget:${PN} ().
Deferring to first boot via 'exit 1' is no longer supported.
Details of the failure are in /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-847819/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0/temp/log.do_rootfs.
ERROR: Logfile of failure stored in: /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-847819/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0/temp/log.do_rootfs.3494045
NOTE: recipe core-image-minimal-1.0-r0: task do_rootfs: Failed
ERROR: Task (/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/recipes-core/images/core-image-minimal.bb:do_rootfs) failed with exit code '1'
NOTE: Tasks Summary: Attempted 4387 tasks of which 4386 didn't need to be rerun and 1 failed.
NOTE: The errors for this build are stored in /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-847819/tmp/log/error-report/error_report_20261103225802.txt
You can send the errors to a reports server by running:
  send-error-report /srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-847819/tmp/log/error-report/error_report_20261103225802.txt [-s server]
NOTE: The contents of these logs will be posted in public if you use the above command with the default server. Please ensure you remove any identifying or proprietary information when prompted before sending.
...
2026-11-03 22:58:43,332 - oe-selftest - INFO - runtime_test.Postinst.test_failing_postinst (subunit.RemotedTestCase)
2026-11-03 22:58:43,333 - oe-selftest - INFO -  ... FAIL
...
2026-11-04 00:03:04,207 - oe-selftest - INFO - FAIL: runtime_test.Postinst.test_failing_postinst (subunit.RemotedTestCase)
2026-11-04 00:03:04,210 - oe-selftest - INFO - ----------------------------------------------------------------------
2026-11-04 00:03:04,210 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/runtime_test.py", line 459, in test_failing_postinst
    self.assertGreaterEqual(bb_result.output.find("Postinstall scriptlets of ['postinst-rootfs-failing'] have failed."), 0,
  File "/usr/lib/python3.12/unittest/case.py", line 1275, in assertGreaterEqual
    self.fail(self._formatMessage(msg, standardMsg))
  File "/usr/lib/python3.12/unittest/case.py", line 715, in fail
    raise self.failureException(msg)
AssertionError: -1 not greater than or equal to 0 : Warning about a failed scriptlet not found in bitbake output: NOTE: Reconnecting to bitbake server...
...
2026-11-03 23:51:38,596 - oe-selftest - INFO - runtime_test.TestImage.test_testimage_install (subunit.RemotedTestCase)
2026-11-03 23:51:38,597 - oe-selftest - INFO -  ... FAIL
...
2026-11-04 00:03:04,274 - oe-selftest - INFO - FAIL: runtime_test.TestImage.test_testimage_install (subunit.RemotedTestCase)
2026-11-04 00:03:04,277 - oe-selftest - INFO - ----------------------------------------------------------------------
2026-11-04 00:03:04,277 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/runtime_test.py", line 131, in test_testimage_install
    bitbake('-c testimage core-image-full-cmdline')
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/utils/commands.py", line 247, in bitbake
    return runCmd(cmd, ignore_status, timeout, output_log=output_log, **options)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/pokybuild/yocto-worker/oe-selftest-debian/build/layers/openembedded-core/meta/lib/oeqa/utils/commands.py", line 214, in runCmd
    raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output))
AssertionError: Command 'bitbake  -c testimage core-image-full-cmdline' returned non-zero exit status 1:
NOTE: Reconnecting to bitbake server...
Loading cache...done.
Loaded 2109 entries from dependency cache.
NOTE: Resolving any missing task queue dependencies

https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/5181
https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/4997
https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/5213

Can you have a look at the issue?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com