From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E925C606A31B for ; Thu, 5 Nov 2026 10:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=saHhjVh3 Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 178A0112318; Thu, 5 Nov 2026 10:28:37 +0000 (UTC) Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1528E112318 for ; Thu, 5 Nov 2026 10:28:31 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 7416E4E40774; Thu, 5 Nov 2026 10:28:29 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 461115FF85; Thu, 5 Nov 2026 10:28:29 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BB50B10329267; Thu, 5 Nov 2026 11:28:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1793874503; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=iBXidrA/iwANgc9GxBZD7IWoRVbP9RFkG8DphNs3/R8=; b=saHhjVh34pVLCuK+4isPs5ULNhBVZ9Yw+GBhtCs1cRWzH3EQmPBD3oXJQRpVGf/gwK8W16 Rz04AOi5wKf4IoW3zPDuKMrKIP+lIL/4Tsji/U4k3cRwa58wCEFktydicARvJcGxFbr+kP /Q/p555FaFrKbDdAbrzt9M1QF9RaDYuGsajFfC8sXWhdrdJ43t9g98zqO6zZFflwr0EZZe LEK097ZDuR8aSsFkzpfaCZCItks8cfvsu/R3/eOhTvb+zpqyaYb1uCQwbY02ZoTrrV98w+ SHIi5LPYK62E1py4LgcSRYHD6r5rpU+Bx0fnlnV8W88unITRNB6Y+0SQOQkqzw== X-Archived-By: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 05 Nov 2026 11:28:16 +0100 Message-Id: Subject: Re: [PATCH v3 2/3] drm/vc4: dsi: stop using deprecated drmm_of_get_bridge() Cc: "Paul Cercueil" , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , To: =?utf-8?q?Ma=C3=ADra_Canal?= , "Luca Ceresoli" , "Maxime Ripard" , "Dave Stevenson" , "Raspberry Pi Kernel Maintenance" , "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" From: "Luca Ceresoli" X-Mailer: aerc 0.22.0 References: <20261013-drm-fix-of_get_bridge-build-regression-v3-0-0b4c0b65be82@bootlin.com> <20261013-drm-fix-of_get_bridge-build-regression-v3-2-0b4c0b65be82@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Sat Oct 24, 2026 at 2:56 PM CEST, Ma=C3=ADra Canal wrote: > Hi Luca, > > On 13/10/26 12:23, Luca Ceresoli wrote: >> drmm_of_get_bridge() is deprecated, switch to >> of_drm_get_bridge_by_endpoint(). As of_drm_get_bridge_by_endpoint() retu= rns >> a refcounted bridge, ensure it is put by using bridge.next_bridge. >> >> drm_panel.h becomes unused, drop the include. >> >> Signed-off-by: Luca Ceresoli ... >> @@ -1165,7 +1163,7 @@ static int vc4_dsi_bridge_attach(struct drm_bridge= *bridge, >> struct vc4_dsi *dsi =3D bridge_to_vc4_dsi(bridge); > > I believe you can delete *dsi > >> >> /* Attach the panel or bridge to the dsi bridge */ >> - return drm_bridge_attach(encoder, dsi->out_bridge, >> + return drm_bridge_attach(encoder, dsi->bridge.next_bridge, > > and use drm_bridge_attach(encoder, bridge->next_bridge, bridge, flags). Good point. I did this in v4 as a new patch, to keep this one patch readable. > Also, I believe the comment is now redundant as panels are just bridges. Indeed, done. > Apart from these nits, could you also address Sashiko's feedback? Sure, fixed in v4. Thanks for reviewing! Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com