Re: [OE-core] [PATCH v12 1/4] libtoml1: fix building tests with gcc 16

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Wed Nov 4, 2026 at 2:20 PM CET, Adam Duskett via openembedded-core wrote:
> GCC 16 warns that the format may be used uninitialized when a value is
> assigned a different type, for example:
>
>   toml::value v(true);
>   v = std::chrono::hours(1);
>
> The warning is a false positive, but the tests build with -Werror, so
> the build fails.
>
> Every operator= copied the old format out of the union behind a type
> check that GCC could not see through, so it flagged a possible read of
> an inactive member.
>
> Add a small helper that keeps the format when the type is unchanged and
> uses the default format otherwise, so the old format is never copied.
> The convenience overloads now convert their argument and forward to the
> main ones, removing a lot of duplicated code.
>
> Fixes:
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/40/builds/4814
>
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---

Hi Adam,

Thanks for the new version. It looks better, with only one selftest
failure, only on ARM hosts.

2026-11-05 09:43:06,955 - oe-selftest - INFO - fitimage.KernelFitImageRecipeTests.test_fit_image_sign_initramfs_bundle (subunit.RemotedTestCase)
2026-11-05 09:43:06,956 - oe-selftest - INFO -  ... FAIL
...
2026-11-05 09:43:06,956 - oe-selftest - INFO - 14: 8/74 452/795 (183.10s) (0 failed) (fitimage.KernelFitImageRecipeTests.test_fit_image_sign_initramfs_bundle)
2026-11-05 09:43:06,956 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/fitimage.py", line 1629, in test_fit_image_sign_initramfs_bundle
    self._test_fitimage(bb_vars)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/fitimage.py", line 719, in _test_fitimage
    fitimage_its_path, fitimage_path = self._bitbake_fit_image(bb_vars)
                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/selftest/cases/fitimage.py", line 828, in _bitbake_fit_image
    bitbake(self.kernel_recipe)
    ~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/utils/commands.py", line 247, in bitbake
    return runCmd(cmd, ignore_status, timeout, output_log=output_log, **options)
  File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/lib/oeqa/utils/commands.py", line 214, in runCmd
    raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output))
AssertionError: Command 'bitbake  linux-yocto-fitimage' returned non-zero exit status 1:
...
ERROR: linux-yocto-fitimage-1.0-r0 do_package_qa: QA Issue: File /boot/fitImage in package linux-yocto-fitimage contains reference to TMPDIR [buildpaths]
ERROR: linux-yocto-fitimage-1.0-r0 do_package_qa: Fatal QA errors were found, failing task.
ERROR: Logfile of failure stored in: /srv/pokybuild/yocto-worker/oe-selftest-armhost/build/build-st-1135637/tmp/work/qemuarm64-poky-linux/linux-yocto-fitimage/1.0/temp/log.do_package_qa.159937
NOTE: recipe linux-yocto-fitimage-1.0-r0: task do_package_qa: Failed
ERROR: Task (/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/layers/openembedded-core/meta/recipes-kernel/linux/linux-yocto-fitimage.bb:do_package_qa) failed with exit code '1'

https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/5224

I know this one might be a bit tricky to reproduce, as it only occurs on
ARM platforms. If you want to run some tests, I can schedule some builds
on the autobuilder.

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com