From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: <sashiko-reviews@lists.linux.dev>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>
Cc: <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm/panel: remove drmm_of_get_bridge()
Date: Fri, 06 Nov 2026 17:48:28 +0100 [thread overview]
Message-ID: <DMOA5EDDS1AS.39CGS8Y3PNPMW@bootlin.com> (raw)
In-Reply-To: <sashiko-outbox-201829@kernel.org>
On Fri Nov 6, 2026 at 5:35 PM CET, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] drm/panel: build failure in vc4 driver after removing
> drmm_of_get_bridge()
> --
>
> commit 4e516e61e060977ea843a480424ba4b15e3d19c9
> Author: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> drm/panel: remove drmm_of_get_bridge()
>
> This commit removes the deprecated drmm_of_get_bridge() helper and its
> header declarations.
[...]
> [Severity: High]
> Does removing drmm_of_get_bridge() break building the vc4 driver?
> vc4_dpi_init_bridge() in drivers/gpu/drm/vc4/vc4_dpi.c and vc4_dsi_bind()
> in drivers/gpu/drm/vc4/vc4_dsi.c still call
> drmm_of_get_bridge(drm, dev->of_node, 0, 0).
Nope, the calls in drivers/gpu/drm/vc4/ have been removed, committed
earlied today on drm-misc-next:
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/5c18e4b11829d9228510d9580027598b54d382e7
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/4a38a538775e072fee707aa28aea5ccd50941796
So patch 1 of this seris removes the only remaining user in drm-misc-next.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-11-06 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 16:17 [PATCH 0/3] drm: remove drmm_of_get_bridge() Luca Ceresoli
2026-11-06 16:17 ` [PATCH 1/3] drm: adp: stop using deprecated drmm_of_get_bridge() Luca Ceresoli
2026-11-06 16:17 ` [PATCH 2/3] drm/panel: remove drmm_of_get_bridge() Luca Ceresoli
2026-11-06 16:35 ` sashiko-bot
2026-11-06 16:48 ` Luca Ceresoli [this message]
2026-11-06 16:17 ` [PATCH 3/3] drm/todo: " Luca Ceresoli
2026-11-06 16:40 ` sashiko-bot
2026-11-08 17:26 ` [PATCH 0/3] drm: " Joshua Peisach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMOA5EDDS1AS.39CGS8Y3PNPMW@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.