Re: [PATCH v2 0/3] credential-cache: fix two races when daemons start at once

["Farid Zakaria" <farid.m.zakaria@gmail.com>]

On Wed Nov 4, 2026 at 11:39 PM PST, Junio C Hamano wrote:
> Farid Zakaria <farid.m.zakaria@gmail.com> writes:
>
>> - Not changed: the socket is still removed at exit through the
>>   tempfile API, which unlinks it without the unix_ss_was_stolen().
>>   There was a discussion with Junio about this. I can do that if it's
>>   a requirement in a V3.
>
> Sorry, but I do not recall having any discussion on this.  
>
> I just pointed out a potential problem, and you sent this version
> out without responding to my review, so I cannot tell why you
> thought it was OK not to address it.  Which means I cannot answer
> "if it's a requirement" question.
>
> Perhaps you had a solid technical reason why the "stolen" detection
> is not necessary, in which case it might be OK.  Perhaps you were
> too lazy to think the issue through, in which case it might not be
> OK.  Or there was some other reason why you thought it is OK not to
> address the issue.

By "discussion" I meant you had flagged some concerns. I considered your response 
a discussion :)

It was not clear to me as someone unfamiliar with the codebase whether the complexity
of handling it was worth it. It seemed like it could only occur during
upgrades (old git version).

My comment was meant to say: I did not address it but I can if we think
it's necessary.