Re: [linux-next:master 3430/4145] kernel/bpf/scev.c:736:33-42: duplicated argument to && or ||

["Alexei Starovoitov" <alexei.starovoitov@gmail.com>]

On Sat Nov 7, 2026 at 11:54 PM UTC, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
> commit: 28a373cb0f6a579049ffe92747575213a442673f [3430/4145] bpf: Fold sums of constants and two shifts by 32 in scalar evolution
> config: hexagon-randconfig-r2101-20261107 (https://download.01.org/0day-ci/archive/20261108/202611080024.A0phXMMa-lkp@intel.com/config)
> compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 0fa861dbbf46e5a75f621406fd91cb015d8754bf)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202611080024.A0phXMMa-lkp@intel.com/
>
> cocci warnings: (new ones prefixed by >>)
>>> kernel/bpf/scev.c:736:33-42: duplicated argument to && or ||

...

>    735				if (class == BPF_ALU64 && op == BPF_RSH && id >= 0 &&
>  > 736				    is_imm(scev, id, &imm) && imm == 32 &&
>    737				    is_binop(scev, BPF_LSH, reg2expr[dst], &l, &r) &&
>    738				    is_imm(scev, r, &imm) && imm == 32)
>    739					return replace_reg(scev, e, dst, expr1(scev, ZEXT32, l));

No. they are not duplicated, but yeah the coding style is questionable.