From: "Pasha Tatashin" <pasha.tatashin@soleen.com>
To: "Pasha Tatashin" <pasha.tatashin@soleen.com>,
"Chris Down" <chris@chrisdown.name>
Cc: <rppt@kernel.org>, <pratyush@kernel.org>, <graf@amazon.com>,
<kexec@lists.infradead.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <kernel-team@meta.com>
Subject: Re: [PATCH] kho: Prevent reuse of preserved pages after a reservation failure
Date: Wed, 11 Nov 2026 16:36:39 -0500 [thread overview]
Message-ID: <DMSPERMRYZKQ.3DKQJXYDDFRS4@soleen.com> (raw)
In-Reply-To: <179443248353.2329176.13720873996862751451.b4-review@b4>
On Wed Nov 11, 2026 at 4:28 PM EST, Pasha Tatashin wrote:
> On Tue, 10 Nov 2026 23:09:30 -0800, Chris Down <chris@chrisdown.name> wrote:
>> kho_preserved_memory_reserve() reserves each range of preserved memory
>> in memblock and marks it noinit, but ignores both return values. Either
>> can fail when memblock has to grow its reserved array and can't find
>> room, which at this point in boot it may only take from KHO bootmem.
>> The boot then goes on as if the range were reserved, and two things
>> can follow:
>>
>> [...]
>
> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
^^^
I mixed up my review threads and replied to this one by mistake. I
intended to reply to: "kho: Reclaim the metadata page left reserved
after kexec". Regardless, we are still waiting for v2 on this patch, and
I will send a separate email regarding the other one.
--
Pasha
prev parent reply other threads:[~2026-11-11 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 7:09 [PATCH] kho: Prevent reuse of preserved pages after a reservation failure Chris Down
2026-11-11 8:01 ` Mike Rapoport
2026-11-11 8:16 ` Chris Down
2026-11-11 9:18 ` Mike Rapoport
2026-11-11 21:28 ` Pasha Tatashin
2026-11-11 21:36 ` Pasha Tatashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMSPERMRYZKQ.3DKQJXYDDFRS4@soleen.com \
--to=pasha.tatashin@soleen.com \
--cc=chris@chrisdown.name \
--cc=graf@amazon.com \
--cc=kernel-team@meta.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.