From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Kang Chen" <k.chen@smail.nju.edu.cn>,
"Yonghong Song" <yonghong.song@linux.dev>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>
Cc: <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf 2/2] selftests/bpf: Test that a drained task_vma iterator keeps returning NULL
Date: Fri, 13 Nov 2026 04:27:41 +0000 [thread overview]
Message-ID: <DMTSS10JMVNJ.VGHU9E75OZ5@gmail.com> (raw)
In-Reply-To: <20261113024500.922824-2-k.chen@smail.nju.edu.cn>
On Thu, Nov 12, 2026 at 06:45 PM Kang Chen <k.chen@smail.nju.edu.cn> wrote:
> + addr = (void *)(unsigned long)skel->bss->last_end;
> + ctx->addr = mmap(addr, getpagesize(), PROT_READ | PROT_WRITE,
> + MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED_NOREPLACE,
> + -1, 0);
This mmap() fails when the test runs after attach_probe in the same
test_progs process.
You didn't even test your AI slop :(
test_task_vma_iter_next_after_drain:FAIL:mmap new VMA unexpected error: 12 (errno 95)
I'm tossing all of your patches out.
Submit them all as one patch series and they better be tested this time.
pw-bot: cr
prev parent reply other threads:[~2026-11-13 4:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 2:44 [PATCH bpf 1/2] bpf: make task_vma iterator stay drained after NULL Kang Chen
2026-11-13 2:45 ` [PATCH bpf 2/2] selftests/bpf: Test that a drained task_vma iterator keeps returning NULL Kang Chen
2026-11-13 3:06 ` sashiko-bot
2026-11-13 4:27 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMTSS10JMVNJ.VGHU9E75OZ5@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=k.chen@smail.nju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.