From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: datrujillo@nvidia.com,
"Daniël Trujillo via B4 Relay"
<devnull+datrujillo.nvidia.com@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"Jiri Olsa" <jolsa@kernel.org>,
"Emil Tsalapatis" <emil@etsalapatis.com>,
"Ihor Solodrai" <ihor.solodrai@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>
Cc: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf] bpf: mask speculative out-of-bounds skb helper loads
Date: Fri, 13 Nov 2026 23:50:45 +0000 [thread overview]
Message-ID: <DMUHIJ5FC8EA.2XFM7TJ6AH0YB@gmail.com> (raw)
In-Reply-To: <20261113-cbpf-ind-nospec-v1-bpf-v1-1-764ac4c14573@nvidia.com>
On Fri, Nov 13, 2026 at 12:15 PM Daniël Trujillo via B4 Relay <devnull+datrujillo.nvidia.com@kernel.org> wrote:
> Mask the load address when the converted offset falls outside the
> permitted range. This removed the leakage in the described setup.
> Derive the lower bound from the network and MAC header
> positions. An out-of-bounds transient offset dereferences NULL instead
> of a potential secret.
I suspect you don't have a reproducer and it's all theoretical.
Because if you had one you would have seen that your patch does nothing.
convert_bpf_ld_abs() inlines the LD_ABS fast
path with its own bounds check.
wont-fix.
pw-bot: cr
prev parent reply other threads:[~2026-11-13 23:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 20:15 [PATCH bpf] bpf: mask speculative out-of-bounds skb helper loads Daniël Trujillo via B4 Relay
2026-11-13 20:15 ` Daniël Trujillo
2026-11-13 20:46 ` bot+bpf-ci
2026-11-13 22:10 ` Daniel Trujillo
2026-11-13 23:50 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMUHIJ5FC8EA.2XFM7TJ6AH0YB@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=datrujillo@nvidia.com \
--cc=davem@davemloft.net \
--cc=devnull+datrujillo.nvidia.com@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.