All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Danilo Krummrich" <dakr@kernel.org>, "Gary Guo" <gary@garyguo.net>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>, <aliceryhl@google.com>,
	<airlied@gmail.com>, <simona@ffwll.ch>, <lossin@kernel.org>,
	<nova-gpu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
	<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] gpu: nova-core: use pin-init self-referential support
Date: Mon, 16 Nov 2026 12:51:52 +0000	[thread overview]
Message-ID: <DMWNDOOCMPVS.4384GVS4DMC5@garyguo.net> (raw)
In-Reply-To: <DMWNA84XI432.TJG95PPPMGPR@kernel.org>

On Mon Nov 16, 2026 at 12:47 PM GMT, Danilo Krummrich wrote:
> On Mon Nov 16, 2026 at 12:52 PM CET, Gary Guo wrote:
>> On Mon Nov 16, 2026 at 7:56 AM GMT, Alexandre Courbot wrote:
>>> On Thu Nov 12, 2026 at 1:19 AM JST, Danilo Krummrich wrote:
>>> <...>
>>>>  drivers/gpu/nova-core/gsp/cmdq.rs     | 16 ++++++--
>>>>  drivers/gpu/nova-core/gsp/cmdq/gmc.rs |  9 +++--
>>>>  drivers/gpu/nova-core/gsp/cmdq/rpc.rs | 11 +++---
>>>
>>> The changes to these files look like they are a change on their own;
>>> they are not using the self-referential support but rather change how
>>> the queue lock is acquired. It should probably be a separate patch
>>> before the rest (which would be the last patch of the series).
>>
>> This is actually integral due to variances, as the existing code more or less
>> relies on cmdq being covariant unsafely. Pin-init is going to enforce that so it
>> needs to be updated to use existential lifetime to make cmdq actually covariant.
>
> Yes, those changes are related to the use of self-referential pin-init. We could
> technically introduce the with_inner_locked() helper separately, but that seems
> excessive and creates unnecessary churn.

Might worth adding a little bit more text into the commit message. The change
itself looks good to me, so with commit message elaborated:

Reviewed-by: Gary Guo <gary@garyguo.net>

Best,
Gary

  reply	other threads:[~2026-11-16 12:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 16:19 [PATCH v2 1/2] gpu: nova-core: minor NovaCoreApi cleanup Danilo Krummrich
2026-11-11 16:19 ` [PATCH v2 2/2] gpu: nova-core: use pin-init self-referential support Danilo Krummrich
2026-11-16  7:56   ` Alexandre Courbot
2026-11-16 11:52     ` Gary Guo
2026-11-16 12:47       ` Danilo Krummrich
2026-11-16 12:51         ` Gary Guo [this message]
2026-11-16 13:59         ` Alexandre Courbot
2026-11-16  7:41 ` [PATCH v2 1/2] gpu: nova-core: minor NovaCoreApi cleanup Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMWNDOOCMPVS.4384GVS4DMC5@garyguo.net \
    --to=gary@garyguo.net \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.