From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794962121; b=kYR+IQxoDtzTIHnrjjaiIREg4iSaq/o+H8UAP8l8k6Vrpz519M9STeFbgGES31Hhtn4M SHpzFSUwWcmBfM7040kel9ndjXkTXr1Ks9CMoMDNTdtXkqXFEBUouSWje4ycjoD3e+QBk ahsh4MNvPerTha8Y1RgZeYAIMOZXeJ40pr9QMfqSDP4FduYAkRqqIaYilqxlygy/OKepy /qgaIRPyn3dnwdXIuf3X0frC3XsyXEY7RXcyKsJzcfu8V602nghtta7Ynz4Keb6Emp4jL deKESOhEVDu6iEypJMtUy53rXJIHt71sKU6hkUjoXvOni3DThRqntg4ZTGsmuP10EZQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794962121; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: Content-Transfer-Encoding:X-Mailer:References:In-Reply-To; bh=WbIzd+ctnJR4yFdsTDfSvvEGuowj5ndViMpewtBSJFs=; b=i3ROBg7QFhakYXdPtfEONh8ywcRay8Y1DTaHi3NtvZ8O+1TsloOLBeE4VoLHHzYBh6fZ eOHIYgQ9LDcVjE6iQfnjtOipDKtX+Qpx8PAp9waa4DbLez7w3U7h6lsiDv1IhMOg+iPJn kt60GO3BNvJowi8LsqAOqiCFBnr4OF0xqhLY40FYkkK0nvYLuqCkuBwWm6TA6z5x6DXdE /kcovJaCP+JsFNzRo3atA35p5l0JZbAL9r8KEGpSxS5mNxEfHznLyqsl9TO1wOWRGlVde NoZAomZ+tIN0H5xU8Hu6hxDfY/Y89iOHdX1NH6LKXZydhFtPOj8dDNtjAkECrrUWEPA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=bQWpC80S; arc=none smtp.remote-ip=209.85.128.53 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE4B5606A32C for ; Wed, 18 Nov 2026 00:35:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CE4B5606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=bQWpC80S Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4a1b07c3c5fso3933725e9.1 for ; Tue, 17 Nov 2026 16:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794962119; x=1795566919; darn=lists.linux.dev; h=in-reply-to:references:content-transfer-encoding:to:from:subject:cc :message-id:date:content-type:mime-version:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WbIzd+ctnJR4yFdsTDfSvvEGuowj5ndViMpewtBSJFs=; b=bQWpC80Sj77jfatDORUYlb23wvCwpDnzh3zkRfsybRtxyTGUsR5tTDbgJkQKuPhJp/ +wQcXIlOJ4adWAK5OEset8Gx1w6yF09V0DyjNqPhv8un206sr9yO1eZo2CYDtM9nQVHK /ZShJ6c0mw8eU7hu8I1XQH3XSo2PeqE8MgVuFx1jWFl6rBh/IOlK4XdGk6oR/6MFmPOW 4mIaFnl2asJqHO+VQWqV1ntDAld2x3sqd3h7bEL/LYekqpzB7bM3Sbew1WqbFEoN+YR9 qqZlOY1jYccQ0te5KrfUHwQM2SyZR7o/awAV93jJLDkUIqaK63Al/Tq3GYJtQTsaMMlg X12A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794962119; x=1795566919; h=in-reply-to:references:content-transfer-encoding:to:from:subject:cc :message-id:date:content-type:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WbIzd+ctnJR4yFdsTDfSvvEGuowj5ndViMpewtBSJFs=; b=WgGDSFe6+zXXOkVTT5Ol9mOWyulBRtsHdsEpggCvt05k9eNvNg97t6IiRItgAcuiKE QlS+HL6d67qU4Eq4KADmsriVIWMVJl1hOkvve/gKQX6vbSB8PbankupnRSEcKfzON+Wq 79puVGNontj74zuHqqGQHCavjI3VQGVI/9TnS+Xj2QytC/Z8eYmzKwFoRTF9kGwz71Bc sQLrDrgqdFNEUMLc4NH53PPeEvPXxe3LX+BFGQ+zSMybbInBA8w569IED6jh6urmRtEq vBQimxyPi1PsGVXBTlzH+3kYvppaBNvJizLdGArOY2DBVrSNJTOqFsFbPbbd6Vtv3lLJ 4suw== X-Forwarded-Encrypted: i=1; AL+hErGgl2LfMOF8NMpQA7fSWCoItX59qHrddDZNCsXXFi+Cnq6jpO724tybtozyymbAi/JHq4lNLQ==@lists.linux.dev X-Gm-Message-State: APuU4Z/kbL62b0/B3+FSUoGqRbqctJzlPj8bH+qlCikG2lT0/Jye4au2 y4f41JUDRjF99Ri2IVJo0N8y97+kkl6t4DSTmDq4jaV1P5Cz+m3Jvqr0 X-Gm-Gg: AYBFou1uUstx2mhluvRNKHKmRpW+z2jmnLbZKV6Yn8+RlPlhwEqz3KTG6XjHghgNqfh qw1IEJTgyNeOGW6nw0KEK80XHqkOrl6qCLglAtE0viTanzyRSIf5dYYh6eqau+nNssvsuRQ0eSj ZYdnvViBk7YbDg+NUDFU5WNiNklaofyObDP8BfHoRlYomBTkAXHbER0ut5H2yJgrTiLSTO096D4 xauhekF/qc9aUqeYHl9SYLV/7/lefobH8PAd0i7eW7yp/uDtwet2BCuTExfBNfITTi4ZzWwQ+o0 reaFwCaWkOQseLO3aD1xEEOdn5FggVWrlsKPKFXbmIvJKn/ww6Z+hK0FyCmDMTkxo2M/H2IWRSl iKBs9Sesqk3QNogUEgJXC1l88Hve54zTcG2isi6qtab/aVGiK4tm9d4JDpNd00ZeIUNoJ0ubRnQ TgVX+kDamkoTG+TdWdKmcELv2xVwpCTxFfDRiyWgRcqRxEu36hdolLbimUQl+ICpdCD0pm2PqiF g60rFM8BrJlBemvGgzOSu0bUA3kjvg1jwBUpclLenNj9ZOFLpTnT69/mPErDjPPufCOXliW44Xq 9pRocKokerV/u6uC6vXgKLULcA== X-Received: by 2002:a05:600c:1906:b0:4b2:2ec5:8a2b with SMTP id 5b1f17b1804b1-4bb7da13900mr16206835e9.10.1794962118973; Tue, 17 Nov 2026 16:35:18 -0800 (PST) Received: from localhost ([2001:b07:5d26:7a6a:365a:60ff:fe0d:cfc6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a65560bd46sm1551151f8f.31.2026.11.17.16.35.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2026 16:35:17 -0800 (PST) X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: multipart/signed; boundary=3f37a8250c17ef201a283aa9d15331a4c7b5582752331b03c03104ec5ba6; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Wed, 18 Nov 2026 01:35:11 +0100 Message-Id: Cc: "Chris Mason" , "Yuezhang Mo" , "Jan Kara" , "NeilBrown" , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Bharath SM" , "Sergey Senozhatsky" , "ChenXiaoSong" , "Darrick J. Wong" , "Sean Smith" , "Andrey Albershteyn" , "Pedro Falcato" , "Amir Goldstein" , =?utf-8?q?Pali_Roh=C3=A1r?= , , , , , , , , Subject: Re: [RFC PATCH v4 07/10] nfsd: add provenance time (ptime) via FATTR4_TIME_CREATE From: "koraynilay" To: "Chuck Lever" , "koraynilay" , "David Sterba" , "Namjae Jeon" , "Sungjong Seo" , "Alexander Viro" , "Christian Brauner" , "Trond Myklebust" , "Anna Schumaker" , "Jeff Layton" , "Konstantin Komarov" , "Paulo Alcantara" Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261115180343.576773-1-koray.fra@gmail.com> <20261115180343.576773-8-koray.fra@gmail.com> In-Reply-To: --3f37a8250c17ef201a283aa9d15331a4c7b5582752331b03c03104ec5ba6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hello and thanks for replying, On Tue Nov 17, 2026 at 11:01 PM CET, Chuck Lever wrote: > > > On Sun, Nov 15, 2026, at 1:03 PM, koraynilay wrote: >> Implement provenance time (ptime) in NFSD, as introduced in a >> previous commit ("vfs: add provenance time (ptime)"). >> >> Map ptime to FATTR4_TIME_CREATE, allowing clients to set it across >> CREATE, OPEN and SETATTR compounds. >> >> If the underlying filesystem supports it, use __vfs_fileattr_set_locked(= ) >> to set it, returning -EOPNOTSUPP in case it's not supported (i.e. when >> __vfs_fileattr_set_locked() returns -ENOIOCTLCMD). >> >> When querying FATTR4_TIME_CREATE, request both STATX_PTIME and >> STATX_BTIME, preferring ptime over btime if available, and advertise >> FATTR4_TIME_CREATE support if either ptime or btime is available. >> >> Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.5.7 >> Signed-off-by: koraynilay > >> @@ -3646,7 +3649,14 @@ static __be32=20 >> nfsd4_encode_fattr4_time_access(struct xdr_stream *xdr, >> static __be32 nfsd4_encode_fattr4_time_create(struct xdr_stream *xdr, >> const struct nfsd4_fattr_args *args) >> { >> - return nfsd4_encode_nfstime4(xdr, &args->stat.btime); >> + const struct timespec64 *ts; >> + >> + if (args->stat.result_mask & STATX_PTIME) >> + ts =3D &args->stat.ptime; >> + else >> + ts =3D &args->stat.btime; >> + >> + return nfsd4_encode_nfstime4(xdr, ts); >> } > > I have trouble with this approach. > > We've already established that, for the Linux in-kernel NFS server > implementation, FATTR4_TIME_CREATE reports a file's birth time and > does not permit NFS clients to modify that. > > After this patch is applied, the server reports the ptime instead > of the btime on some filesystems but not others. I implemented it in this way to have a proof-of-concept of how ptime could be use by filesystems that already support settable btime (as was suggested to me in [1]). There was also a discussion in v3[2] on NFS's FATTR4_TIME_CREATE as an example of such a filesystem > Essentially this changes the semantics of existing files that have > a btime set -- technically that's a regression. and since the NFS protocol itself states that FATTR4_TIME_CREATE should be user-settable, I think adhering more to it would be better. This would be fine even for already existing files IMO, since btime =3D=3D ptime if the user doesn't manually change it (or with --preserve=3Dptime for the various copying tools). Thanks, koraynilay [1]: https://lore.kernel.org/CAOQ4uxiuy0VwZj+3M-zRqQ49WTpHZpiaQ+6MZ8z8WdLjy= QM_zA@mail.gmail.com/ [2]: https://lore.kernel.org/20261103094906.n55n5dhrpct5ykmw@pali/ --3f37a8250c17ef201a283aa9d15331a4c7b5582752331b03c03104ec5ba6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSgVimKafU5DQMcjcDmj22qf5IGXAUCavzyvwAKCRDmj22qf5IG XOsRAP4vh5FXH5uGRieLcNxmpyXktFYo5TTK0/smQUKH1S3W4AD+OFSrMDbk0OBL bbF4a80MG9QJTSNaQXnZOrSA4Bhhew4= =tiHS -----END PGP SIGNATURE----- --3f37a8250c17ef201a283aa9d15331a4c7b5582752331b03c03104ec5ba6--