From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Kurt Lin" <lylin1023@gmail.com>, "Hui Zhu" <hui.zhu@linux.dev>,
"Hui Zhu" <zhuhui@kylinos.cn>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
<bpf@vger.kernel.org>
Cc: "Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"Jiri Olsa" <jolsa@kernel.org>,
"Ihor Solodrai" <ihor.solodrai@linux.dev>,
"Emil Tsalapatis" <emil@etsalapatis.com>,
"Barry Song" <baohua@kernel.org>, "Shuah Khan" <shuah@kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2] selftests/bpf: Fall back when memcg_proactive_reclaim data lands in shmem
Date: Wed, 18 Nov 2026 03:49:05 +0000 [thread overview]
Message-ID: <DMY136RTAL9Q.2WQSZ57W1YLV2@gmail.com> (raw)
In-Reply-To: <20261117170704.1146730-1-lylin1023@gmail.com>
On Tue, Nov 17, 2026 at 09:07 AM Kurt Lin <lylin1023@gmail.com> wrote:
> After writing the file, check memory.stat and move on to the next
> candidate directory if most of the data was charged as shmem; skip only
> when none is left. Give each candidate its own cgroup so that stale
> stats from a previous attempt cannot interfere, and poll memory.stat
> until the write shows up, as reading it does not force a stats flush.
> Fail the test if memory.stat cannot be read or never shows the write.
This is overkill.
> To exercise the polling, FILE_SIZE was temporarily cut to 2 MiB in a
> 128-vCPU guest, which keeps the write below the flush threshold.
So the test with 32 MiB didn't hit it.
Pls don't add code just because a bot said so.
Here is what I mean. I didn't compile it:
diff --git a/tools/testing/selftests/bpf/prog_tests/arena_memcg.c b/tools/testing/selftests/bpf/prog_tests/arena_memcg.c
index c76a7eb..334bfa6 100644
--- a/tools/testing/selftests/bpf/prog_tests/arena_memcg.c
+++ b/tools/testing/selftests/bpf/prog_tests/arena_memcg.c
@@ -53,8 +53,12 @@ static int alloc_pagecache(size_t size)
fd = open(".", O_TMPFILE | O_RDWR | O_EXCL, 0600);
if (fd < 0)
return errno == EOPNOTSUPP ? -EOPNOTSUPP : -1;
- /* tmpfs hands out shmem pages, which are not reclaimable without swap */
- if (fstatfs(fd, &stfs) || stfs.f_type == TMPFS_MAGIC) {
+ /*
+ * tmpfs hands out shmem pages, which are not reclaimable without swap.
+ * overlayfs hides the type of its upper layer, which can be tmpfs.
+ */
+ if (fstatfs(fd, &stfs) || stfs.f_type == TMPFS_MAGIC ||
+ stfs.f_type == OVERLAYFS_SUPER_MAGIC) {
close(fd);
return -EOPNOTSUPP;
}
diff --git a/tools/testing/selftests/bpf/prog_tests/memcg_proactive_reclaim.c b/tools/testing/selftests/bpf/prog_tests/memcg_proactive_reclaim.c
index c22dcfa..2ba0791 100644
--- a/tools/testing/selftests/bpf/prog_tests/memcg_proactive_reclaim.c
+++ b/tools/testing/selftests/bpf/prog_tests/memcg_proactive_reclaim.c
@@ -30,7 +30,8 @@ struct reclaim_args {
* being available, and a read-only mount cannot host the file at all (EROFS
* applies to root too). /tmp is tmpfs on many systems, and test_progs is
* routinely run from a tmpfs working directory, so both candidates need the
- * check.
+ * check. overlayfs hides the type of its upper layer, which is tmpfs for /tmp
+ * in virtme-ng guests.
*/
static const char *workload_dir(void)
{
@@ -40,7 +41,8 @@ static const char *workload_dir(void)
for (i = 0; i < ARRAY_SIZE(dirs); i++)
if (!statfs(dirs[i], &st) && st.f_type != TMPFS_MAGIC &&
- st.f_type != RAMFS_MAGIC && !access(dirs[i], W_OK))
+ st.f_type != RAMFS_MAGIC &&
+ st.f_type != OVERLAYFS_SUPER_MAGIC && !access(dirs[i], W_OK))
return dirs[i];
return NULL;
pw-bot: cr
prev parent reply other threads:[~2026-11-18 3:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 17:07 [PATCH bpf-next v2] selftests/bpf: Fall back when memcg_proactive_reclaim data lands in shmem Kurt Lin
2026-11-18 3:49 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMY136RTAL9Q.2WQSZ57W1YLV2@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=baohua@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=hui.zhu@linux.dev \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lylin1023@gmail.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
--cc=zhuhui@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.