All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul Louvel" <paul.louvel@bootlin.com>
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Paul Louvel" <paul.louvel@bootlin.com>
Cc: "Borislav Petkov" <bp@alien8.de>,
	"Tony Luck" <tony.luck@intel.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>, <linux-edac@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Herve Codina" <herve.codina@bootlin.com>
Subject: Re: [PATCH v7 3/3] ARM: dts: renesas: r9a06g032: add EDAC node
Date: Wed, 18 Nov 2026 10:39:37 +0100	[thread overview]
Message-ID: <DMY8JKQSCVRK.2ZLAAS9PECBV0@bootlin.com> (raw)
In-Reply-To: <avzCbuXANntvBPDz@shikoro>

Hello,

On Tue Nov 17, 2026 at 10:09 PM CET, Wolfram Sang wrote:
> Hi Paul,
>
>> > On second thought, any reason we don't want this enabled by default?
>> 
>> Please see my answer to Geert [1].
>> After reconsideration, maybe it is advisable to enable it by default. Enabling
>> ECC is done by the bootloader, and it might be better if no further actions are
>> required to enable it kernel side.
>> If ECC is disabled, no errors will be generated, and the capabilties will just be
>> set to EDAC_CAP_NONE.
>
> I agree that enabling ECC belongs to the bootloader. With the current DT
> bindings, the Linux driver continues to work on whatever it has been set
> up before (which may be nothing), or? From that point of view, I think
> it makes sense to enable it by default. But again, my knowledge is
> limited here...

The EDAC_CAP_NONE reported in the struct mem_ctl_info structure if ECC is
disabled is just used once in the EDAC subsystem [1] and is purely
informational. If ECC is disabled, no interrupts will be generated in case of an
error and cdns_mc_err_handler().

So there is no risk of any side effects if the driver is enabled and ECC is
disabled by the bootloader.

I will set it to enabled by default on the next iteration.

[1]: https://elixir.bootlin.com/linux/v7.3.1/source/drivers/edac/edac_mc.c#L125

>
> Thanks and happy hacking,
>
>    Wolfram

Thanks.
Best regards,
-- 
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      parent reply	other threads:[~2026-11-18  9:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 14:43 [PATCH v7 0/3] Add Renesas RZ/N1x EDAC driver Paul Louvel
2026-10-19 14:43 ` [PATCH v7 1/3] dt-bindings: edac: cdns,ddr-edac: add Cadence DDR EDAC Paul Louvel
2026-10-19 14:43 ` [PATCH v7 2/3] EDAC/cadence: Add Cadence DDR EDAC driver Paul Louvel
2026-11-17 13:07   ` Wolfram Sang
2026-10-19 14:43 ` [PATCH v7 3/3] ARM: dts: renesas: r9a06g032: add EDAC node Paul Louvel
2026-11-17 13:08   ` Wolfram Sang
2026-11-17 13:46     ` Paul Louvel
2026-11-17 21:09       ` Wolfram Sang
2026-11-18  7:46         ` Geert Uytterhoeven
2026-11-18  9:39         ` Paul Louvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMY8JKQSCVRK.2ZLAAS9PECBV0@bootlin.com \
    --to=paul.louvel@bootlin.com \
    --cc=bp@alien8.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=herve.codina@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tony.luck@intel.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.