From: "Danilo Krummrich" <dakr@kernel.org>
To: "Alexandre Courbot" <acourbot@nvidia.com>
Cc: <aliceryhl@google.com>, <abdiel.janulgue@gmail.com>,
<daniel.almeida@collabora.com>, <robin.murphy@arm.com>,
<a.hindborg@kernel.org>, <ojeda@kernel.org>, <boqun@kernel.org>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<lossin@kernel.org>, <tmgross@umich.edu>, <tamird@kernel.org>,
<work@onurozkan.dev>, <driver-core@lists.linux.dev>,
<nova-gpu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 1/2] rust: scatterlist: tie owned tables to the device's bound lifetime
Date: Wed, 18 Nov 2026 23:45:49 +0100 [thread overview]
Message-ID: <DMYP9JMEAF53.13MHUJHT7J420@kernel.org> (raw)
In-Reply-To: <DMWC45NN5L9I.2NUG81ETBC84L@nvidia.com>
On Mon Nov 16, 2026 at 5:02 AM CET, Alexandre Courbot wrote:
> The `RawSGTable` documentation still mentions `Owned`. We could adapt it
> or (maybe better) just drop that sentence.
[...]
> `sgt` is removed by this patch.
diff --git a/rust/kernel/scatterlist.rs b/rust/kernel/scatterlist.rs
index 93f431d7f548..22d039f3fdb1 100644
--- a/rust/kernel/scatterlist.rs
+++ b/rust/kernel/scatterlist.rs
@@ -214,9 +214,6 @@ fn drop(&mut self) {
}
/// A transparent wrapper around a `struct sg_table`.
-///
-/// While we could also create the `struct sg_table` in the constructor of [`Owned`], we can't tear
-/// down the `struct sg_table` in [`Owned::drop`]; the drop order in [`Owned`] matters.
#[repr(transparent)]
struct RawSGTable(Opaque<bindings::sg_table>);
@@ -282,7 +279,6 @@ fn drop(&mut self) {
/// A [`SGTable<Owned>`] signifies that the [`SGTable`] owns all associated resources:
///
/// - The backing memory pages.
-/// - The `struct sg_table` allocation (`sgt`).
/// - The DMA mapping, released before the table and backing pages are freed.
///
/// Users interact with this type through the [`SGTable`] handle and do not need to manage
next prev parent reply other threads:[~2026-11-18 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 23:42 [PATCH 1/2] rust: scatterlist: tie owned tables to the device's bound lifetime Danilo Krummrich
2026-11-14 23:42 ` [PATCH 2/2] gpu: nova-core: remove unnecessary firmware pin-init Danilo Krummrich
2026-11-16 4:02 ` Alexandre Courbot
2026-11-16 12:29 ` Danilo Krummrich
2026-11-16 13:57 ` Alexandre Courbot
2026-11-19 7:27 ` Philipp Stanner
2026-11-16 4:02 ` [PATCH 1/2] rust: scatterlist: tie owned tables to the device's bound lifetime Alexandre Courbot
2026-11-16 12:43 ` Danilo Krummrich
2026-11-16 12:49 ` Gary Guo
2026-11-16 13:16 ` Danilo Krummrich
2026-11-18 22:45 ` Danilo Krummrich [this message]
2026-11-19 0:45 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMYP9JMEAF53.13MHUJHT7J420@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=abdiel.janulgue@gmail.com \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.