From: "koraynilay" <koray.fra@gmail.com>
To: "Lauri Gates" <lauri.gates@gmail.com>, "Dave Chinner" <dgc@kernel.org>
Cc: "Christian Brauner" <brauner@kernel.org>,
"Christoph Hellwig" <hch@infradead.org>,
<linux-xfs@vger.kernel.org>, "Carlos Maiolino" <cem@kernel.org>,
"Christian Brauner" <christian@brauner.io>,
"Darrick J. Wong" <djwong@kernel.org>,
<linux-api@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-btrfs@vger.kernel.org>, <ocfs2-devel@lists.linux.dev>,
<linux-nfs@vger.kernel.org>, <linux-cifs@vger.kernel.org>,
"Amir Goldstein" <amir73il@gmail.com>
Subject: Re: Concurrent FIEMAP on reflinked files serialises on the AGF buffer lock
Date: Thu, 19 Nov 2026 12:00:04 +0100 [thread overview]
Message-ID: <DMZ4VQ7SZ07T.29WMPQ0BQZGSS@gmail.com> (raw)
In-Reply-To: <20261119095943.85048-1-lauri.gates@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 9733 bytes --]
On Thu Nov 19, 2026 at 10:59 AM CET, Lauri Gates wrote:
> On Wed, Nov 18, 2026 at 10:16PM +0200, Dave Chinner wrote:
>> I really don't care if it is exposed by statx or file_attr; checking
>> the flag through either interface will be orders of magnitude faster
>> than using FIEMAP to iterate extents on every file to find shared
>> extents. My concern with statx is coherency - it runs completely
>> unlocked and so can race with operations that add/remove the reflink
>> flag...
>
> Thanks, Dave and Christian. Given Christian's preference and the
> coherency point, I'll write the RFC against file_attr, once the
> question at the end is settled. xfs_fileattr_get() already reads the
> flags under XFS_ILOCK_SHARED, so the new flag gets that without extra
> work. The answer can still go stale right after the call, as with any
> stat result: a clone that lands after the read is missed, just as one
> that lands after FIEMAP returns is missed today.
>
> As I suggested on the 6th, the flag would take the inverted meaning,
> so that an unset flag stays the safe answer: say FS_XFLAG_NOSHARED
> ("no extents shared with another file"), read-only, in
> FS_XFLAG_RDONLY_MASK next to the case-folding flags.
Hello, I don't have any say in the FIEMAP issue, but I wanted to let you
know that, since also a mask was mentioned and your patch would be
touching the fileattr API, there is work going[1] on for adding a
fsx_xflags_mask that filesystem use[2][3] to advertise supported flags (on
get, like stx_attributes_mask) and users use to say what they want to
change (on set).
It doesn't seem like an FS_XFLAG_NOSHARED flag would touch this new
change, but I thought it was worth pointing out, especially because this
patch would also add FS_XFLAG_PROJID and a new FS_FILE_ATTR_XFLAGS_MASK
to have a way to include both legacy and newly added xflags, so
FS_XFLAG_NOSHARED would maybe also go there (correct me if I'm wrong).
> Christian, one question on the shape within file_attr: would you take
> the inverted flag, or would you rather keep a plain "may share" flag
> and add a mask to struct file_attr that says which xflags the
> filesystem reports?
And if Christian chooses the mask approach, then my patch[4] becomes
relevant.
(in [4] I put the patch that will be sent in v5 of [1], since in [1]
it's merged with the ptime change)
(For Amir who I just CC'd, [5] is the main link for this thread)
Thanks,
koraynilay
[1]: https://lore.kernel.org/all/20261115180343.576773-1-koray.fra@gmail.com/T/#u
[2]: https://lore.kernel.org/all/CAOQ4uxj82K4z+2OiY5W1g7NyWAFOFjqqWnZSS3prytW36j1LgA@mail.gmail.com/
[3]: https://lore.kernel.org/all/CAOQ4uxiuJ=eZu28FZAUz3rpqPKqCimPxJucOnYYuBowvD09_Cw@mail.gmail.com/
[5]: https://lore.kernel.org/linux-xfs/20261102193533.93690-1-lauri.gates@gmail.com/T/#u
[4]:
commit 0efe0de3b5cc2b767aa6e2bb9174eb05b0d818f1
Author: koraynilay <koray.fra@gmail.com>
Date: Tue Nov 17 14:57:47 2026 +0100
vfs: add xflags mask to file_attr API
Add fa_xflags_mask to struct file_attr and equivalent fsx_xflags_mask
to struct file_kattr.
This lets filesystems advertise their support for specific xflags and
users specify only what they want to change, behaving like
statx.stx_attributes_mask:
- on GET (file_getattr): each filesystem fills the mask according to
its supported xflags, e.g. FS_XFLAG_COWEXTSIZE or FS_XFLAG_EXTSIZE,
and provides the values in the corresponding struct fields;
- on SET (file_setattr): userspace fills the mask according to which
xflags it wants to change, VFS validates this and preserves xflags
that were not specified in the mask;
- if xflags_mask == 0, use legacy full-struct replacement to keep
compatibility with older programs.
Furthermore, add the missing FS_XFLAG_PROJID flag, to allow userspace to
set the projid using file_[sg]etattr().
Finally, in order to prevent the legacy FS_IOC_FSSETXATTR from accepting
FS_XFLAG_PROJID, add an FS_FILE_ATTR_XFLAGS_MASK to support new xflags
and use it in fileattr_to_file_attr()/file_attr_to_fileattr() to
validate that the xflags passed in fa_xflags and fa_xflags_mask fields
are valid.
Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.5.7
Signed-off-by: koraynilay <koray.fra@gmail.com>
---
fs/file_attr.c | 46 ++++++++++++++++++++++++++++++++++++++++++----
include/linux/fileattr.h | 5 +++++
include/uapi/linux/fs.h | 3 +++
3 files changed, 50 insertions(+), 4 deletions(-)
diff --git a/fs/file_attr.c b/fs/file_attr.c
index 833e03810b24..56ea65f790f1 100644
--- a/fs/file_attr.c
+++ b/fs/file_attr.c
@@ -102,10 +102,18 @@ EXPORT_SYMBOL(vfs_fileattr_get);
static void fileattr_to_file_attr(const struct file_kattr *fa,
struct file_attr *fattr)
{
- __u32 mask = FS_XFLAGS_MASK;
+ /*
+ * fsx_xflags_mask contains only flags added after the
+ * file_[gs]etattr() API, so we need to tell userspace the filesystem
+ * actually supports all legacy (FS_XFLAGS_MASK and FS_XFLAG_PROJID,
+ * which lacked its own bit) and new advertised flags.
+ */
+ __u32 mask = (FS_XFLAGS_MASK | FS_XFLAG_PROJID | fa->fsx_xflags_mask) &
+ FS_FILE_ATTR_XFLAGS_MASK;
memset(fattr, 0, sizeof(struct file_attr));
fattr->fa_xflags = fa->fsx_xflags & mask;
+ fattr->fa_xflags_mask = mask;
fattr->fa_extsize = fa->fsx_extsize;
fattr->fa_nextents = fa->fsx_nextents;
fattr->fa_projid = fa->fsx_projid;
@@ -141,12 +149,17 @@ EXPORT_SYMBOL(copy_fsxattr_to_user);
static int file_attr_to_fileattr(const struct file_attr *fattr,
struct file_kattr *fa)
{
- __u64 mask = FS_XFLAGS_MASK;
+ __u64 mask = fattr->fa_xflags_mask ?: FS_XFLAGS_MASK;
+
+ if (fattr->fa_xflags_mask & ~FS_FILE_ATTR_XFLAGS_MASK)
+ return -EINVAL;
if (fattr->fa_xflags & ~mask)
return -EINVAL;
- fileattr_fill_xflags(fa, fattr->fa_xflags & ~FS_XFLAG_RDONLY_MASK);
+ fileattr_fill_xflags(fa, fattr->fa_xflags & FS_XFLAGS_MASK &
+ ~FS_XFLAG_RDONLY_MASK);
+ fa->fsx_xflags_mask = fattr->fa_xflags_mask;
fa->fsx_extsize = fattr->fa_extsize;
fa->fsx_projid = fattr->fa_projid;
fa->fsx_cowextsize = fattr->fa_cowextsize;
@@ -288,12 +301,37 @@ int vfs_fileattr_set(const struct mnt_idmap *idmap, struct dentry *dentry,
if (!err) {
/* initialize missing bits from old_ma */
if (fa->flags_valid) {
- fa->fsx_xflags |= old_ma.fsx_xflags & ~FS_XFLAG_COMMON;
+ /* FS_IOC_SETFLAGS */
+ fa->fsx_xflags_mask = 0;
+ fa->fsx_xflags |= (old_ma.fsx_xflags & FS_XFLAGS_MASK) &
+ ~FS_XFLAG_COMMON;
fa->fsx_extsize = old_ma.fsx_extsize;
fa->fsx_nextents = old_ma.fsx_nextents;
fa->fsx_projid = old_ma.fsx_projid;
fa->fsx_cowextsize = old_ma.fsx_cowextsize;
} else {
+ /*
+ * Preserve unmasked xflags when running file_setattr()
+ * with a mask, which doesn't need a read-modify-write
+ * so these attributes would be set to 0.
+ *
+ * With FS_IOC_FSSETXATTR or mask == 0 (legacy mode)
+ * this is not needed as userspace does
+ * read-modify-write already.
+ */
+ if (fa->fsx_xflags_mask) {
+ fa->fsx_xflags |= (old_ma.fsx_xflags & FS_XFLAGS_MASK) &
+ ~fa->fsx_xflags_mask;
+ fileattr_fill_xflags(fa, fa->fsx_xflags &
+ ~FS_XFLAG_RDONLY_MASK);
+ if (!(fa->fsx_xflags_mask &
+ (FS_XFLAG_EXTSIZE | FS_XFLAG_EXTSZINHERIT)))
+ fa->fsx_extsize = old_ma.fsx_extsize;
+ if (!(fa->fsx_xflags_mask & FS_XFLAG_PROJID))
+ fa->fsx_projid = old_ma.fsx_projid;
+ if (!(fa->fsx_xflags_mask & FS_XFLAG_COWEXTSIZE))
+ fa->fsx_cowextsize = old_ma.fsx_cowextsize;
+ }
fa->flags |= old_ma.flags & ~FS_COMMON_FL;
}
diff --git a/include/linux/fileattr.h b/include/linux/fileattr.h
index 09e32b84e02a..40ecb29f6235 100644
--- a/include/linux/fileattr.h
+++ b/include/linux/fileattr.h
@@ -35,6 +35,10 @@
(FS_XFLAG_COMMON | FS_XFLAG_RDONLY_MASK | FS_XFLAG_VALUES_MASK | \
FS_XFLAG_DIRONLY_MASK | FS_XFLAG_MISC_MASK)
+/* Flags only for fa_ fields */
+#define FS_FILE_ATTR_XFLAGS_MASK \
+ (FS_XFLAGS_MASK | FS_XFLAG_PROJID)
+
/*
* Merged interface for miscellaneous file attributes. 'flags' originates from
* ext* and 'fsx_flags' from xfs. There's some overlap between the two, which
@@ -45,6 +49,7 @@ struct file_kattr {
u32 flags; /* flags (FS_IOC_GETFLAGS/FS_IOC_SETFLAGS) */
/* struct fsxattr: */
u32 fsx_xflags; /* xflags field value (get/set) */
+ u32 fsx_xflags_mask; /* supported xflags (get) / flags to set (set) */
u32 fsx_extsize; /* extsize field value (get/set)*/
u32 fsx_nextents; /* nextents field value (get) */
u32 fsx_projid; /* project identifier (get/set) */
diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
index a46c33692aa2..b168f1b75126 100644
--- a/include/uapi/linux/fs.h
+++ b/include/uapi/linux/fs.h
@@ -229,6 +229,7 @@ struct file_attr {
__u32 fa_nextents; /* nextents field value (get) */
__u32 fa_projid; /* project identifier (get/set) */
__u32 fa_cowextsize; /* CoW extsize field value (get/set) */
+ __u32 fa_xflags_mask; /* supported xflags (get) / flags to set (set) */
};
#define FILE_ATTR_SIZE_VER0 24
@@ -261,6 +262,8 @@ struct file_attr {
*/
#define FS_XFLAG_CASEFOLD 0x00040000 /* case-insensitive lookups */
#define FS_XFLAG_CASENONPRESERVING 0x00080000 /* case not preserved */
+
+#define FS_XFLAG_PROJID 0x00200000 /* project ID */
#define FS_XFLAG_HASATTR 0x80000000 /* no DIFLAG for this */
/* the read-only stuff doesn't really belong here, but any other place is
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-11-19 11:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 19:32 Concurrent FIEMAP on reflinked files serialises on the AGF buffer lock Lauri Gates
2026-11-03 5:25 ` Christoph Hellwig
2026-11-04 12:41 ` Lauri Gates
2026-11-04 21:11 ` Dave Chinner
2026-11-06 15:21 ` Christoph Hellwig
2026-11-04 21:04 ` Dave Chinner
2026-11-06 12:23 ` Lauri Gates
2026-11-06 15:20 ` Christoph Hellwig
2026-11-06 20:40 ` Lauri Gates
2026-11-12 20:05 ` Christoph Hellwig
2026-11-17 16:22 ` Christian Brauner
2026-11-18 20:16 ` Dave Chinner
2026-11-19 9:59 ` Lauri Gates
2026-11-19 11:00 ` koraynilay [this message]
2026-11-19 15:32 ` Lauri Gates
2026-11-19 17:04 ` Amir Goldstein
2026-11-19 22:21 ` koraynilay
2026-11-20 5:52 ` Amir Goldstein
2026-11-20 14:12 ` koraynilay
2026-11-20 14:35 ` Amir Goldstein
2026-11-20 14:44 ` koraynilay
2026-11-13 3:37 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMZ4VQ7SZ07T.29WMPQ0BQZGSS@gmail.com \
--to=koray.fra@gmail.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=christian@brauner.io \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=lauri.gates@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.