From: "Antonin Godard" <antonin.godard@bootlin.com>
To: "Quentin Schulz" <quentin.schulz@cherry.de>,
<docs@lists.yoctoproject.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/4] tools/gen-releases-svg: start showing releases from oldest active one
Date: Fri, 20 Nov 2026 09:12:46 +0100 [thread overview]
Message-ID: <DMZVY66DTQYK.1QRZXJ9LWNQ49@bootlin.com> (raw)
In-Reply-To: <f188f220-d21f-4953-b56d-80e56f293e4b@cherry.de>
On Thu Nov 19, 2026 at 1:48 PM CET, Quentin Schulz wrote:
> Hi Antonin,
>
> On 11/19/26 8:55 AM, Antonin Godard wrote:
[...]
>
> question: ways to get a more meaningful diff?
>
> Phew, that's a mouthful. Do you know if there's any way to maybe not
> minify the SVG so the diff is more palatable?
I wish it did, but didn't find an option to do so with Mermaid, even being able
to output it with some indentation :/
>> index 6a601b010..77281f37d 100755
>> --- a/documentation/tools/gen-releases-svg
>> +++ b/documentation/tools/gen-releases-svg
>> @@ -54,6 +54,16 @@ gantt
>> with open(args.releases_json_path, "r") as f:
>> releases_from_json = json.load(f)
>>
>> +# Find the oldest active release release date to make it the start of our timeline.
>> +active_release_dates = []
>> +for release in releases_from_json:
>> + if release["series"] == "previous":
>> + continue
>> + if not release["original_release_date"]:
>> + continue
>> + active_release_dates.append(datetime.datetime.strptime(release["original_release_date"], "%Y-%m-%dT%H:%M:%S%z"))
>> +oldest_supported_release_date = sorted(active_release_dates)[0]
>> +
>
> suggestion: ditch the array
>
> No need for an array, simply keep the oldest date.
>
> oldest_supported_release_date = datetime.datetime.now()
> for release in releases_from_json:
> if release["series"] == "previous":
> continue
> if not release["original_release_date"]:
> continue
> oldest_supported_release_date = min(oldest_supported_release_date,
> datetime.datetime.strptime(release["original_release_date"],
> "%Y-%m-%dT%H:%M:%S%z"))
Yup, better thanks!
Antonin
next prev parent reply other threads:[~2026-11-20 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 7:55 [PATCH 0/4] tools/gen-releases-svg: fixes/improvements Antonin Godard
2026-11-19 7:55 ` [PATCH 1/4] tools/gen-releases-svg: use subprocess check_call instead of run Antonin Godard
2026-11-19 12:30 ` Quentin Schulz
2026-11-19 7:55 ` [PATCH 2/4] tools/gen-releases-svg: start showing releases from oldest active one Antonin Godard
2026-11-19 12:48 ` Quentin Schulz
2026-11-20 8:12 ` Antonin Godard [this message]
2026-11-19 7:55 ` [PATCH 3/4] tools/gen-releases-svg: store docs root dir in variable Antonin Godard
2026-11-19 12:53 ` Quentin Schulz
2026-11-19 7:55 ` [PATCH 4/4] tools/gen-releases-svg: simplify tempfile usage Antonin Godard
2026-11-19 12:59 ` Quentin Schulz
2026-11-20 8:12 ` [docs] " Antonin Godard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMZVY66DTQYK.1QRZXJ9LWNQ49@bootlin.com \
--to=antonin.godard@bootlin.com \
--cc=docs@lists.yoctoproject.org \
--cc=quentin.schulz@cherry.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.