From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.51 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795181033; b=DJxzpbbMQKBRgfqwlNaDuatY06WhVH+eySQzokem96fxuZ9PYgJ6dnaUv72lBM2TwmpT KY8nqOiOL7qj0Q3DcmZVfjy1vD65oRH4yY3DO3gVXEXG91wEDUl8B2e2pASUa/7FjeN8l hh9nwKf+klSh4Ywgrm+DklORCQ5+ZK1d0c8zeGumDtkjx4V+6ZeWVIRE8TSPdp01/pCTL juTfomU/Xd+eHTpb2zBvuKJgEZt+fgnHR4nf0CnLs4fOYBgzWXvkHD86KiSJ8eU0nxYbh SxFjXrChkT18IbSUy5F/IIPOARZEQbKw8TKn5iTJhzEvCVMj7HM0vtmASNcXmgU9HxA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795181033; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject:X-Mailer: References:In-Reply-To; bh=U9t5C73ir3/3QySglAwAwVOJ69q66296+82EjWEvxrc=; b=xRfllGa7Bgb5qEcU5fZBNdktKt4/70K9KtoPjnRpJ8Op1md7ZOXKTy9cvvB7riQQdrn/ hfVbxO4A2jRNgA0FvtnJdjl7snZQZTh7MKeQgWJbViIPmT4+zf1pP1rYVO7dxBJsx9tgQ qYfXoXvY/3fOlLjLhvqCZycPUn/PdxHArEM5kQmlILYNlwFy2bxip0AssvkjUi8G0hBFk NWFiYHkihbZn41M2h5SyZw9Bt7ELA13Yat9o088TK1YSHdhe3gcwYYkQPPThlE/g60XxY k24re7FfrrgtlU3Sr+XDGwvpJtnnGTF6rbsddzt6Ysut0tABsftntY+lPi6gqJEJD+Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=TUVe1kLT; arc=none smtp.remote-ip=209.85.128.51 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9818760A2616 for ; Fri, 20 Nov 2026 13:23:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9818760A2616 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=TUVe1kLT Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4b79502c27aso8128315e9.1 for ; Fri, 20 Nov 2026 05:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795181031; x=1795785831; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-type:mime-version:from:to:cc:subject:date:message-id :reply-to:content-type; bh=U9t5C73ir3/3QySglAwAwVOJ69q66296+82EjWEvxrc=; b=TUVe1kLTe1RrGjkZcB0Jll6qRkbhub5RAYrrBdXYAW7cCWc5ZfKjmtHsxejUWkMmqG JzPS+ZpHkP7wYDJTT9lXMucUyvaeiJXactdfcKWcDDB8coLAUlZ+SLxV/1HOPt72Y8vR ZlJc2GAvUJ9zeSXBUpYabS2EM7tBgAyo4jIeTRVyCxLex4cLnS2ZffMAZOHSFIBuAhgb IhJ9TGzBnVeS+qk3W+h/M+Afxb+UT1xmww35AkhR+sZmys0qIASFOsZUqQF5VUqAX1D4 CPz+yTqfhss6B38ZRKGfmP0RMlFT5D9wepGDZqnoCfxFFAl5qcguvOeWnzTzLCK4pe1x 4Yxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795181031; x=1795785831; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-type:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=U9t5C73ir3/3QySglAwAwVOJ69q66296+82EjWEvxrc=; b=qrTLOVds0d7XTrVDX+UKajtIptaYwPtb9NMCp1ueAJHaU6StW+T3iBwOChObxLgAsE pCC9nj3urMscs4+BHeFptXDSYALukMaPkE1GyPdAVW23C8nWF3CH8/f3lWUHZrxzSQBs xLvTAQ3GoM85G+lAPW1ikXrEummSZu5ZrMNTNX9Ufr3QFUmNWHMU+Goc+bqsMMwpbM6u 3MhtcRQtUKm0f4+wiVQRV/a714wkfMpG0TNbjac60BERx8zXjZTYRAkB724POOqUfc7X 037+JdJCeXp0ToNjos/WoCWU3kWbQaj1V9gIxNH0lgNM4fM1HBPqqRHTDwrjXtiUEmKy chbQ== X-Forwarded-Encrypted: i=1; AL+hErGFZgLIjawejt5LvHdwGY6f4pXeeyqtX0M7sxpQUphWpv0M8J01G1RJxS0RQZFDNNgtbkZzytBRykBgCquV@vger.kernel.org X-Gm-Message-State: APuU4Z9HneKr4gz920GchW4OLTAp3eeI74DWOonDci6D2AIMoxpsJpZd 7juB/tve+GkI4h+qF83KlOxAGzp1YLmQjmN/vsEDrvyst8TqXkt/ejpP X-Gm-Gg: AYBFou2lcA+NeXdxBEEhDfRz5VSBaDRk8fAvXWamztDbIfao1XwGQRrTQggMmAvmKjl T1P7B3M1qhowyM4DlTbpaPvCB75qMvvfux8edFqQ5V+YLUbK9T6HLPR6R9ilgB3eItyUi7/1Fki kbF+GAdhtQ8/80cx2wOGN58HnSi+9YT9eCoB+2aoWoPMOE2dR0EFT5ryAZotnB6v+GcqbsbjmnU XLtwFuo/2HXI3Q2wIc/v/2ltQpSUHJqQs35Zn+3EAfNQ/TykMPQmA/S7ts9MnPhjaWGGZZm8Np7 ehG6ueClLRknsPcPggkspoUhLAKtdxbrUz/xvZIp84UD9x4XAjrN0DF7ki70+9reYVp81+6nlHC WhzjvJ0CFjIoqRYBA2RMqrR6s0POgZOkPuAFEy6jjU2sk6R8br0JwyH5H1I0zGEyYtDloA1rEh3 aoesAKBj1vwSKl52YMttcif6qAtKsdKUwct4LmbbI7Yatwz6N0BLeYL+WatkyTBDsBrgx1S7ZTV 3lrt7BolUrGqPfEOoKSi1PjojR20klyPnpNLEOrgLlfsaJBS5/VxNWZ3ei/YZ21BNp0/1DKGo4t fHB3ZUr40BLbayYMGjTaAkgmOGfgBM0D/ffkMWYnaS9JTrRj X-Received: by 2002:a05:600c:3b83:b0:4b7:6b96:e431 with SMTP id 5b1f17b1804b1-4bb88822242mr75040685e9.28.1795181030668; Fri, 20 Nov 2026 05:23:50 -0800 (PST) Received: from localhost ([130.192.98.149]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab65cb41f4sm5518234f8f.7.2026.11.20.05.23.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2026 05:23:49 -0800 (PST) X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Type: multipart/signed; boundary=7e8bd4a9c12ebb9d8a66b83f0766d89a19a194b2b3f96510da164a6c43d9; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Fri, 20 Nov 2026 14:23:41 +0100 Message-Id: From: "koraynilay" To: "Amir Goldstein" , "koraynilay" Cc: =?utf-8?q?Pali_Roh=C3=A1r?= , "David Sterba" , "Namjae Jeon" , "Sungjong Seo" , "Alexander Viro" , "Christian Brauner" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Jeff Layton" , "Konstantin Komarov" , "Paulo Alcantara" , "Chris Mason" , "Yuezhang Mo" , "Jan Kara" , "NeilBrown" , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Bharath SM" , "Sergey Senozhatsky" , "ChenXiaoSong" , "Darrick J . Wong" , "Sean Smith" , "Andrey Albershteyn" , "Pedro Falcato" , , , , , , , , Subject: Re: [RFC PATCH v4 09/10] ksmbd: add provenance time (ptime) and map it to CreationTime X-Mailer: aerc 0.22.0-0-gc2f86b7abde3 References: <20261115180343.576773-1-koray.fra@gmail.com> <20261115180343.576773-10-koray.fra@gmail.com> <20261119220936.mssmaixcorn2gzli@pali> In-Reply-To: --7e8bd4a9c12ebb9d8a66b83f0766d89a19a194b2b3f96510da164a6c43d9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Fri Nov 20, 2026 at 7:03 AM CET, Amir Goldstein wrote: > On Thu, Nov 19, 2026 at 11:25=E2=80=AFPM koraynilay = wrote: >> >> On Thu Nov 19, 2026 at 11:09 PM CET, Pali Roh=C3=A1r wrote: >> > On Thursday 19 November 2026 22:51:26 koraynilay wrote: >> >> On Thu Nov 19, 2026 at 6:34 PM CET, Amir Goldstein wrote: >> >> > On Sun, Nov 15, 2026 at 7:04=E2=80=AFPM koraynilay wrote: >> >> >> >> >> >> Implement provenance time (ptime) in ksmbd, as introduced in a >> >> >> previous commit ("vfs: add provenance time (ptime)"). >> >> >> >> >> >> Map it to SMB's CreationTime, making it settable by SMB clients. W= hen >> >> >> reporting CreationTime to clients, prioritize ptime over da.create= _time >> >> >> memorized in the user.DOSATTRIB xattr. >> >> > >> >> > That doesn't sound like the right thing to do. >> >> > >> >> > If the server stored a CreationTime that client had set, you cannot >> >> > override this. >> >> >> >> Ah, yes, but how would we handle older files which get a custom >> >> CreationTime both before (in the xattr) and after (in ptime) a kernel >> >> upgrade? >> > >> > Just to note that this problem is already there. ksmbd can export for >> > example ntfs filesystem on removable disk. And this removable disk can >> > be connected to Windows machine which will always only touch >> > CreationTime and ignores xattr DOSATTRIB. >> > >> >> > When the client sets CreationTime, the server can decide if it can = and wants >> >> > (may be a policy decision) to store CreationTime in PTIME and not s= tore >> >> > it in user.DOSATTRIB. >> >> >> >> To fix the above problem we should probably keep storing it in both >> >> ptime and the xattr though. >> > >> > IMHO for a long term solution it is better to not have duplicated >> > information in xattr. Because duplicated information are going to be >> > out-of-sync. Windows NTFS driver will not update xattr DOSATTRIB. >> >> Yeah, to avoid out-of-sync issues is why I made ksmbd prefer ptime over >> the xattr's CreationTime. >> >> > >> > For me it looks like that this needs some policy / configuration >> > decision done by user. We do not know if the user will replug that dis= k >> > also to Windows NTFS driver (and then those xattr DOSATTRIB could caus= e >> > out-of-sync issues) or will only use it from Linux or Samba and then >> > xattr DOSATTRIB is probably fine. >> >> I'm not sure if this is the best solution, it doesn't feel too right >> to me, but maybe there isn't a better one. >> > > If you ask me, this is not your problem and I agree with Pali that > this is a policy decision. > > I would not include this patch at all in the series if I were you. > Maybe as a demo user, but you could just as well include a demo > user application. Ah, ok, fair. > The nfsd user is a simpler demo, so as long as the nfsd maintainers > are on the same page wrt the mutable btime plan, you could include > it in your series. > > The problem you raise with DOSATTRIB xattr is similar to the problems > that Chuck raised for ptime vs. btime as the source of FATTR4_TIME_CREATE Ah right, I can see the parallel, tho before the ptime change you couldn't modify the creation time at all from linux with nfsd, so in that case unless a user manually changed it after a kernel upgrade, it wouldn't have this desync problem (apart from a kernel downgrade). Thanks, koraynilay > Thanks, > Amir. --7e8bd4a9c12ebb9d8a66b83f0766d89a19a194b2b3f96510da164a6c43d9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRJ2XvJtXGwULYEerQ0bnTtJTDoOAUCawBJ3gAKCRA0bnTtJTDo OJc/AQCn/pvK3+PSezucUXa1GtiKLjE7oMlXGStcJfzdnlWtcAD9GPZFH0ccIs4C afAlaO9nsoqLSUJ3Hk7qioPrnGVqrQM= =CBTM -----END PGP SIGNATURE----- --7e8bd4a9c12ebb9d8a66b83f0766d89a19a194b2b3f96510da164a6c43d9--