From: Rusty Russell <rusty@linuxcare.com.au>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)
Date: Sat, 16 Dec 2000 00:12:31 +1100 [thread overview]
Message-ID: <E146uf1-0000Dq-00@halfway> (raw)
In-Reply-To: Your message of "Thu, 14 Dec 2000 12:23:19 -0800." <200012142023.MAA12823@pizda.ninka.net>
In message <200012142023.MAA12823@pizda.ninka.net> you write:
> Date: Thu, 14 Dec 2000 15:35:48 -0500 (EST)
> From: "Mohammad A. Haque" <mhaque@haque.net>
>
> I'll be trying in a few hours.
>
> Meanwhile for people wanting the crashes to be fixed, please
> apply this patch.
>
> This was _always_ broken, and really what netfilter is doing
> should have never worked. The only theory I have right now
> is that people using netfilter never had IP fragments timeout.
> :-)
Ick, we've previously had issues with using the defrag routine from
PRE_ROUTING (Andi fixed the `called without bh disabled' problem). 8(
Good news is that it's all done from one place:
net/ipv4/ip_conntrack_core.c:910:ip_ct_gather_frags(struct sk_buff *skb)
You can fix it to obey the rules there, rather than hacking fragment
code.
Cheers,
Rusty.
--
Hacking time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-17 8:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-13 23:22 test12 lockups -- need feedback Mohammad A. Haque
2000-12-14 0:22 ` Mikael Djurfeldt
2000-12-14 0:29 ` Mikael Djurfeldt
2000-12-14 1:28 ` dep
2000-12-14 2:58 ` Mohammad A. Haque
2000-12-14 3:48 ` Mohammad A. Haque
2000-12-14 12:21 ` Ingo Oeser
2000-12-14 11:42 ` Mohammad A. Haque
2000-12-15 15:20 ` Ingo Oeser
2000-12-14 12:10 ` dep
2000-12-14 12:15 ` Mohammad A. Haque
2000-12-14 13:16 ` dep
2000-12-14 14:41 ` Bob_Tracy
2000-12-14 18:38 ` ip_defrag is broken (was: Re: test12 lockups -- need feedback) Ion Badulescu
2000-12-14 19:27 ` David S. Miller
2000-12-14 19:52 ` Ion Badulescu
2000-12-14 19:43 ` David S. Miller
2000-12-14 20:07 ` Ion Badulescu
2000-12-14 19:55 ` Netfilter is broken (was Re: ip_defrag is broken (was: Re: test12 lockups -- need feedback)) David S. Miller
2000-12-15 0:20 ` Harald Welte
2000-12-15 0:11 ` David S. Miller
2000-12-15 0:48 ` Andi Kleen
2000-12-15 1:25 ` Harald Welte
2000-12-14 20:35 ` ip_defrag is broken (was: Re: test12 lockups -- need feedback) Mohammad A. Haque
2000-12-14 20:23 ` David S. Miller
2000-12-14 21:25 ` Mohammad A. Haque
2000-12-14 22:50 ` Mohammad A. Haque
2000-12-14 23:58 ` Mohammad A. Haque
2000-12-15 8:52 ` Jasper Spaans
2000-12-15 9:22 ` Tom Leete
2000-12-15 2:25 ` Tom Leete
2000-12-15 13:12 ` Rusty Russell [this message]
2000-12-14 20:49 ` Bob_Tracy
-- strict thread matches above, loose matches on Subject: below --
2000-12-14 22:39 Bob_Tracy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E146uf1-0000Dq-00@halfway \
--to=rusty@linuxcare.com.au \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.