From: Rusty Russell <rusty@linuxcare.com.au>
To: Eric Berenguier <Eric.Berenguier@sycomore.fr>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: PATCH: ipfwadm IP accounting (2.4.1)
Date: Wed, 07 Feb 2001 14:37:57 +1100 [thread overview]
Message-ID: <E14QLQb-0002Tp-00@halfway> (raw)
In-Reply-To: Your message of "Tue, 06 Feb 2001 13:38:37 BST." <l0310280ab6a59b6a53d3@[172.30.8.86]>
In message <l0310280ab6a59b6a53d3@[172.30.8.86]> you write:
> Using ipfwadm on a 2.4.1 kernel, some ip accouting rules for outgoing
> packets have theirs packet and byte counter stuck to 0 value. There is no
> such problem with incoming packets.
Hi Eric!
You're exactly right: it was a typo. Thanks.
Linus, please apply.
Rusty.
--- linux-2.4.1/net/ipv4/netfilter/ip_fw_compat.c Tue Feb 6 11:10:01 2001
+++ linux/net/ipv4/netfilter/ip_fw_compat.c Tue Feb 6 09:03:17 2001
@@ -132,7 +132,7 @@
if (ret == FW_ACCEPT || ret == FW_SKIP) {
if (fwops->fw_acct_out)
fwops->fw_acct_out(fwops, PF_INET,
- (struct net_device *)in,
+ (struct net_device *)out,
(*pskb)->nh.raw, &redirpt,
pskb);
confirm_connection(*pskb);
--
Premature optmztion is rt of all evl. --DK
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2001-02-07 3:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-06 12:38 PATCH: ipfwadm IP accounting (2.4.1) Eric Berenguier
2001-02-07 3:37 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E14QLQb-0002Tp-00@halfway \
--to=rusty@linuxcare.com.au \
--cc=Eric.Berenguier@sycomore.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.