From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@zip.com.au>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [patch] scalable timers implementation, 2.4.16, 2.5.0
Date: Thu, 06 Dec 2001 13:15:42 +1100 [thread overview]
Message-ID: <E16Bo4c-00031f-00@wagner> (raw)
In-Reply-To: Your message of "Wed, 05 Dec 2001 14:13:17 -0800." <3C0E9BFD.BC189E17@zip.com.au>
In message <3C0E9BFD.BC189E17@zip.com.au> you write:
> Rusty Russell wrote:
> >
> > PS. Also would be nice to #define del_timer del_timer_sync, and have a
> > del_timer_async for those (very few) cases who really want this.
>
> That could cause very subtle deadlocks. I'd prefer to do:
>
> #define del_timer_async del_timer
I'd prefer to audit them all, create a patch, and remove del_timer.
Doing it slowly usually means things just get forgotten, then hacked
around when it finally gets ripped out.
The deadlock you're referring to is, I assume, del_timer_sync() called
inside the timer itself? Can you think of any other dangerous cases?
Rusty.
--
Anyone who quotes me is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2001-12-06 2:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-27 14:57 [patch] scalable timers implementation, 2.4.16, 2.5.0 Ingo Molnar
2001-12-05 21:29 ` Rusty Russell
2001-12-05 22:13 ` Andrew Morton
2001-12-06 2:15 ` Rusty Russell [this message]
2001-12-06 4:20 ` Andrew Morton
2001-12-06 9:10 ` Alan Cox
2001-12-06 10:41 ` Ingo Molnar
[not found] <3C0E9BFD.BC189E17@zip.com.au.suse.lists.linux.kernel>
[not found] ` <E16Bo4c-00031f-00@wagner.suse.lists.linux.kernel>
2001-12-06 2:32 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E16Bo4c-00031f-00@wagner \
--to=rusty@rustcorp.com.au \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.