From: Daniel Phillips <phillips@arcor.de>
To: Andrew Morton <akpm@zip.com.au>, davidm@hpl.hp.com
Cc: linux-kernel@vger.kernel.org, davidm@napali.hpl.hp.com
Subject: Re: page-flags.h pollution?
Date: Sun, 1 Sep 2002 23:34:39 +0200 [thread overview]
Message-ID: <E17lcMi-0004c8-00@starship> (raw)
In-Reply-To: <3D6F12A4.285DF44@zip.com.au>
On Friday 30 August 2002 08:37, Andrew Morton wrote:
> David Mosberger wrote:
> >
> > In the 2.5.3x kernel, what's the point of defining pte_chain_lock()
> > and pte_chain_unlock() in page-flags.h? These two routines make it
> > impossible to include page-flags.h on it's own, because they require
> > "struct page" to be defined (and a forward declaration isn't
> > sufficient either). This can introduce rather annoying circular
> > include-file dependencies.
>
> It's a wart. The now-abandoned hashed spinlocking patch moves
> them into <linux/rmap-locking.h>. We can do that anyway - only
> two files need it.
>
> Or maybe just put them in asm-generic/rmap.h. I'll fix it up.
Yup. As a matter of principle, headers for data should be separated from
headers for operations.
--
Daniel
prev parent reply other threads:[~2002-09-01 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-30 5:56 page-flags.h pollution? David Mosberger
2002-08-30 6:37 ` Andrew Morton
2002-09-01 21:34 ` Daniel Phillips [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17lcMi-0004c8-00@starship \
--to=phillips@arcor.de \
--cc=akpm@zip.com.au \
--cc=davidm@hpl.hp.com \
--cc=davidm@napali.hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.