Re: patch for hammerfall driver

[Paul Davis <paul@linuxaudiosystems.com>]

>> To be explicit:  whenever you see a bug, don't just
>> ask how to fix this instance of the bug;  ask what
>> it would take to make sure no bug of this ilk ever
>> occurs again.
>> 
>> In this case:
>>   a) It would help to have some comments in the code
>> saying where the constants are coming from, so that
>> misconceptions can be more easily spotted.
>>   b) It would help to use correctly computed constants
>> such as

actually, neither would have really helped very much here. i don't
know who set the values to those that were here before. the values
were clearly wrong on any reading of the code, and i've thought about
them on previous readings. the values that were there before were not
"buggy" - they were completely wrong.

the problem here was social rather than technical: i never had a
reason or the time to do anything to answer my questions about the
values that were there.

the last few days have seen me trying to debug some rather deep
problems with a specific hdsp configuration, and i wanted to run JACK
with 8192 frame periods. i couldn't do it, and ended up having to go
back and deal with those numbers so that i could. 

>>   c) When applying the sizeof() operator, don't
>> apply it to general-purpose types such as int, but
>> rather apply it to an object that is provably
>> of the type you care about, in this case something

agreed. i had meant to remove the sizeof() from the patch before i
posted it. 

--p


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com