From: janitor@sternwelten.at
To: netdev@oss.sgi.com
Cc: jgarzik@pobox.com, jt@hpl.hp.com, janitor@sternwelten.at
Subject: [patch 1/8] irda/act200l-sir: replace schedule_timeout() with msleep()
Date: Wed, 01 Sep 2004 23:05:23 +0200 [thread overview]
Message-ID: <E1C2cIF-0007yy-Lb@sputnik> (raw)
I would appreciate any comments from the janitor@sternweltens list.
Description: Replace schedule_timeout() with msleep() to guarantee the
task delays for the desired time.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.9-rc1-bk7-max/drivers/net/irda/act200l-sir.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/net/irda/act200l-sir.c~msleep-drivers_net_irda_act200l-sir drivers/net/irda/act200l-sir.c
--- linux-2.6.9-rc1-bk7/drivers/net/irda/act200l-sir.c~msleep-drivers_net_irda_act200l-sir 2004-09-01 19:35:31.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/net/irda/act200l-sir.c 2004-09-01 19:35:31.000000000 +0200
@@ -177,8 +177,7 @@ static int act200l_change_speed(struct s
/* Write control bytes */
sirdev_raw_write(dev, control, 3);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(msecs_to_jiffies(5));
+ msleep(5);
/* Go back to normal mode */
sirdev_set_dtr_rts(dev, TRUE, TRUE);
_
next reply other threads:[~2004-09-01 21:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 21:05 janitor [this message]
2004-09-01 21:09 ` [patch 1/8] irda/act200l-sir: replace schedule_timeout() with msleep() Jean Tourrilhes
2004-09-01 21:40 ` [Kernel-janitors] Re: [patch 1/8] irda/act200l-sir: replace maximilian attems
2004-09-01 21:40 ` [Kernel-janitors] Re: [patch 1/8] irda/act200l-sir: replace schedule_timeout() with msleep() maximilian attems
2004-09-01 21:48 ` [Kernel-janitors] Re: [patch 1/8] irda/act200l-sir: replace Jean Tourrilhes
2004-09-01 21:48 ` [patch 1/8] irda/act200l-sir: replace schedule_timeout() with msleep() Jean Tourrilhes
2004-09-01 22:03 ` [Kernel-janitors] Re: [patch 1/8] irda/act200l-sir: replace Nishanth Aravamudan
2004-09-01 22:03 ` [Kernel-janitors] Re: [patch 1/8] irda/act200l-sir: replace schedule_timeout() with msleep() Nishanth Aravamudan
2004-09-01 22:58 ` [Kernel-janitors] Re: [patch 1/8] irda/act200l-sir: replace maximilian attems
2004-09-01 22:58 ` [Kernel-janitors] Re: [patch 1/8] irda/act200l-sir: replace schedule_timeout() with msleep() maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1C2cIF-0007yy-Lb@sputnik \
--to=janitor@sternwelten.at \
--cc=jgarzik@pobox.com \
--cc=jt@hpl.hp.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.