All of lore.kernel.org
 help / color / mirror / Atom feed
From: janitor@sternwelten.at
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at
Subject: [patch 04/14]  radio/radio-aimslab: replace 	while/schedule() with msleep()
Date: Thu, 02 Sep 2004 01:16:00 +0200	[thread overview]
Message-ID: <E1C2eKf-0002mH-2f@sputnik> (raw)







I would appreciate any comments from the janitor@sternweltens list.

Thanks,
Nish



Description: Uses msleep() instead of a while-loop and schedule(). Thus
the CPU is given up for the time desired.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-aimslab.c |    7 +------
 1 files changed, 1 insertion(+), 6 deletions(-)

diff -puN drivers/media/radio/radio-aimslab.c~msleep-drivers_media_radio-aimslab drivers/media/radio/radio-aimslab.c
--- linux-2.6.9-rc1-bk7/drivers/media/radio/radio-aimslab.c~msleep-drivers_media_radio-aimslab	2004-09-01 19:35:10.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-aimslab.c	2004-09-01 19:35:10.000000000 +0200
@@ -63,12 +63,7 @@ static void sleep_delay(long n)
 	if(!d)
 		udelay(n);
 	else
-	{
-		/* Yield CPU time */
-		unsigned long x=jiffies;
-		while((jiffies-x)<=d)
-			schedule();
-	}
+		msleep(jiffies_to_msecs(d));
 }
 
 static void rt_decvol(void)

_

                 reply	other threads:[~2004-09-01 23:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1C2eKf-0002mH-2f@sputnik \
    --to=janitor@sternwelten.at \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.