From: janitor@sternwelten.at
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, janitor@sternwelten.at
Subject: [patch 09/14] radio/radio-sf16fmi: replace schedule_timeout() with msleep()
Date: Thu, 02 Sep 2004 01:16:28 +0200 [thread overview]
Message-ID: <E1C2eL6-0002pp-AW@sputnik> (raw)
I would appreciate any comments from the janitor@sternweltens list.
Thanks,
Nish
Description: Replaced schedule_timeout() with msleep() to guarantee the
task delays the desired time.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-sf16fmi.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff -puN drivers/media/radio/radio-sf16fmi.c~msleep-drivers_media_radio-sf16fmi drivers/media/radio/radio-sf16fmi.c
--- linux-2.6.9-rc1-bk7/drivers/media/radio/radio-sf16fmi.c~msleep-drivers_media_radio-sf16fmi 2004-09-01 19:35:13.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/media/radio/radio-sf16fmi.c 2004-09-01 19:35:13.000000000 +0200
@@ -89,8 +89,7 @@ static inline int fmi_setfreq(struct fmi
outbits(16, RSF16_ENCODE(freq), myport);
outbits(8, 0xC0, myport);
- current->state = TASK_UNINTERRUPTIBLE;
- schedule_timeout(HZ/7);
+ msleep(143); /* was schedule_timeout(HZ/7) */
up(&lock);
if (dev->curvol) fmi_unmute(myport);
return 0;
@@ -107,8 +106,7 @@ static inline int fmi_getsigstr(struct f
val = dev->curvol ? 0x08 : 0x00; /* unmute/mute */
outb(val, myport);
outb(val | 0x10, myport);
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ/7);
+ msleep(143); /* was schedule_timeout(HZ/7) */
res = (int)inb(myport+1);
outb(val, myport);
_
reply other threads:[~2004-09-01 23:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1C2eL6-0002pp-AW@sputnik \
--to=janitor@sternwelten.at \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.