From: janitor@sternwelten.at
To: dwmw2@redhat.com
Cc: nacc@us.ibm.com, janitor@sternwelten.at, linux-mtd@lists.infradead.org
Subject: [patch 4/4] mtd/cfi_cmdset_0020: replace schedule_timeout() with msleep()
Date: Thu, 23 Sep 2004 22:42:05 +0200 [thread overview]
Message-ID: <E1CAaPl-00028K-AF@sputnik> (raw)
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.9-rc2-bk7-max/drivers/mtd/chips/cfi_cmdset_0020.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff -puN drivers/mtd/chips/cfi_cmdset_0020.c~msleep-drivers_mtd_chips_cfi_cmdset_0020 drivers/mtd/chips/cfi_cmdset_0020.c
--- linux-2.6.9-rc2-bk7/drivers/mtd/chips/cfi_cmdset_0020.c~msleep-drivers_mtd_chips_cfi_cmdset_0020 2004-09-21 21:07:48.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/mtd/chips/cfi_cmdset_0020.c 2004-09-21 21:07:48.000000000 +0200
@@ -788,7 +788,7 @@ retry:
chip->state = FL_ERASING;
spin_unlock_bh(chip->mutex);
- schedule_timeout(HZ);
+ msleep(1000);
spin_lock_bh(chip->mutex);
/* FIXME. Use a timer to check this, and return immediately. */
@@ -1087,7 +1087,7 @@ retry:
chip->state = FL_LOCKING;
spin_unlock_bh(chip->mutex);
- schedule_timeout(HZ);
+ msleep(1000);
spin_lock_bh(chip->mutex);
/* FIXME. Use a timer to check this, and return immediately. */
@@ -1236,7 +1236,7 @@ retry:
chip->state = FL_UNLOCKING;
spin_unlock_bh(chip->mutex);
- schedule_timeout(HZ);
+ msleep(1000);
spin_lock_bh(chip->mutex);
/* FIXME. Use a timer to check this, and return immediately. */
_
reply other threads:[~2004-09-23 20:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1CAaPl-00028K-AF@sputnik \
--to=janitor@sternwelten.at \
--cc=dwmw2@redhat.com \
--cc=linux-mtd@lists.infradead.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.