From: Miklos Szeredi <miklos@szeredi.hu>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] FUSE: nfsd with direct_io fix
Date: Sun, 24 Apr 2005 17:41:13 +0200 [thread overview]
Message-ID: <E1DPjEP-0000O7-00@localhost> (raw)
This patch fixes an Oops which happens when a filesystem mounted with
the "direct_io" mount option is exported through NFS. The problem is
that nfsd passes a kernel buffer with the "set_fs(KERNEL_DS)" method
to read and write, but get_user_pages() won't work on such a buffer.
The current fix is "don't do that then". Long term solution will be
to implement nfs serving in userspace. Bug spotted by David Shaw.
Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
diff -rup linux-2.6.12-rc2-mm3/fs/fuse/file.c linux-fuse/fs/fuse/file.c
--- linux-2.6.12-rc2-mm3/fs/fuse/file.c 2005-04-22 16:00:19.000000000 +0200
+++ linux-fuse/fs/fuse/file.c 2005-04-22 15:50:32.000000000 +0200
@@ -409,6 +409,10 @@ static int fuse_get_user_pages(struct fu
unsigned offset = user_addr & ~PAGE_MASK;
int npages;
+ /* This doesn't work with nfsd */
+ if (!current->mm)
+ return -EPERM;
+
nbytes = min(nbytes, (unsigned) FUSE_MAX_PAGES_PER_REQ << PAGE_SHIFT);
npages = (nbytes + offset + PAGE_SIZE - 1) >> PAGE_SHIFT;
npages = min(npages, FUSE_MAX_PAGES_PER_REQ);
reply other threads:[~2005-04-24 15:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1DPjEP-0000O7-00@localhost \
--to=miklos@szeredi.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.