From: Bodo Eggert <harvested.in.lkml@7eggert.dyndns.org>
To: Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, akpm@osdl.org, hpa@zytor.com,
mm-commits@vger.kernel.org
Subject: Re: + git-klibc-mktemp-fix.patch added to -mm tree
Date: Sun, 09 Apr 2006 01:34:42 +0200 [thread overview]
Message-ID: <E1FSMxM-0001Ir-1J@be1.lrz> (raw)
In-Reply-To: 5Zs4F-ba-11@gated-at.bofh.it
Sam Ravnborg <sam@ravnborg.org> wrote:
> On Sat, Apr 08, 2006 at 12:05:54AM -0700, akpm@osdl.org wrote:
>> diff -puN usr/dash/mkbuiltins~git-klibc-mktemp-fix usr/dash/mkbuiltins
>> --- 25/usr/dash/mkbuiltins~git-klibc-mktemp-fix Sat Apr 8 14:51:11 2006
>> +++ 25-akpm/usr/dash/mkbuiltins Sat Apr 8 14:51:11 2006
>> - tempfile=mktemp
>> + tempfile="mktemp /tmp/tmp.XXXXXX"
>
> Shouldn't that be:
>> + tempfile="$(mktemp /tmp/tmp.XXXXXX)"
No. You should use tempfile="$(mktemp ${TMPDIR:-/tmp}/tmp.XXXXXX)"
(or mktemp -t, if it's portable enough)
Besides that, tmp.XXXXXX should be replayed using a better name.
</nitpick>
--
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.
next parent reply other threads:[~2006-04-08 23:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5Zs4F-ba-13@gated-at.bofh.it>
[not found] ` <5Zs4F-ba-11@gated-at.bofh.it>
2006-04-08 23:34 ` Bodo Eggert [this message]
[not found] <200604080707.k38778VV023208@shell0.pdx.osdl.net>
2006-04-08 20:14 ` + git-klibc-mktemp-fix.patch added to -mm tree Sam Ravnborg
2006-04-08 20:27 ` H. Peter Anvin
2006-04-09 5:33 ` Herbert Xu
2006-04-10 7:33 ` Keith Owens
2006-04-10 14:45 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1FSMxM-0001Ir-1J@be1.lrz \
--to=harvested.in.lkml@7eggert.dyndns.org \
--cc=7eggert@gmx.de \
--cc=akpm@osdl.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.