From: Herbert Valerio Riedel <hvr@gnu.org>
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org,
sshtylyov@ru.mvista.com
Subject: [PATCH] au1000_eth.c: use ether_crc() from <linux/crc32.h>
Date: Mon May 1 15:37:09 2006 +0200 [thread overview]
Message-ID: <E1FaYil-0007A8-HB@fencepost.gnu.org> (raw)
since the au1000 driver already selects the CRC32 routines, simply replace
the internal ether_crc() implementation with the semantically equivalent
one from <linux/crc32.h>
Signed-off-by: Herbert Valerio Riedel <hvr@gnu.org>
---
drivers/net/au1000_eth.c | 18 +-----------------
1 files changed, 1 insertions(+), 17 deletions(-)
9360df5368deaaaa8fc7dcaacf9b7ca446af94c4
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
index 29adebb..0823cb8 100644
--- a/drivers/net/au1000_eth.c
+++ b/drivers/net/au1000_eth.c
@@ -52,6 +52,7 @@
#include <linux/mii.h>
#include <linux/skbuff.h>
#include <linux/delay.h>
+#include <linux/crc32.h>
#include <asm/mipsregs.h>
#include <asm/irq.h>
#include <asm/io.h>
@@ -2070,23 +2071,6 @@ static void au1000_tx_timeout(struct net
netif_wake_queue(dev);
}
-
-static unsigned const ethernet_polynomial = 0x04c11db7U;
-static inline u32 ether_crc(int length, unsigned char *data)
-{
- int crc = -1;
-
- while(--length >= 0) {
- unsigned char current_octet = *data++;
- int bit;
- for (bit = 0; bit < 8; bit++, current_octet >>= 1)
- crc = (crc << 1) ^
- ((crc < 0) ^ (current_octet & 1) ?
- ethernet_polynomial : 0);
- }
- return crc;
-}
-
static void set_rx_mode(struct net_device *dev)
{
struct au1000_private *aup = (struct au1000_private *) dev->priv;
--
1.2.6
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Valerio Riedel <hvr@gnu.org>
To: jgarzik@pobox.com
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org,
sshtylyov@ru.mvista.com
Subject: [PATCH] au1000_eth.c: use ether_crc() from <linux/crc32.h>
Date: Mon, 1 May 2006 13:46:04 +0000 (UTC)
Date: Mon May 1 15:37:09 2006 +0200 [thread overview]
Message-ID: <E1FaYil-0007A8-HB@fencepost.gnu.org> (raw)
since the au1000 driver already selects the CRC32 routines, simply replace
the internal ether_crc() implementation with the semantically equivalent
one from <linux/crc32.h>
Signed-off-by: Herbert Valerio Riedel <hvr@gnu.org>
---
drivers/net/au1000_eth.c | 18 +-----------------
1 files changed, 1 insertions(+), 17 deletions(-)
9360df5368deaaaa8fc7dcaacf9b7ca446af94c4
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
index 29adebb..0823cb8 100644
--- a/drivers/net/au1000_eth.c
+++ b/drivers/net/au1000_eth.c
@@ -52,6 +52,7 @@
#include <linux/mii.h>
#include <linux/skbuff.h>
#include <linux/delay.h>
+#include <linux/crc32.h>
#include <asm/mipsregs.h>
#include <asm/irq.h>
#include <asm/io.h>
@@ -2070,23 +2071,6 @@ static void au1000_tx_timeout(struct net
netif_wake_queue(dev);
}
-
-static unsigned const ethernet_polynomial = 0x04c11db7U;
-static inline u32 ether_crc(int length, unsigned char *data)
-{
- int crc = -1;
-
- while(--length >= 0) {
- unsigned char current_octet = *data++;
- int bit;
- for (bit = 0; bit < 8; bit++, current_octet >>= 1)
- crc = (crc << 1) ^
- ((crc < 0) ^ (current_octet & 1) ?
- ethernet_polynomial : 0);
- }
- return crc;
-}
-
static void set_rx_mode(struct net_device *dev)
{
struct au1000_private *aup = (struct au1000_private *) dev->priv;
--
1.2.6
next reply other threads:[~2006-05-01 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-01 13:37 Herbert Valerio Riedel [this message]
2006-05-01 13:46 ` [PATCH] au1000_eth.c: use ether_crc() from <linux/crc32.h> Herbert Valerio Riedel
2006-05-02 20:34 ` Ralf Baechle
2006-05-24 5:29 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-05-01 13:46 Herbert Valerio Riedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1FaYil-0007A8-HB@fencepost.gnu.org \
--to=hvr@gnu.org \
--cc=jgarzik@pobox.com \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.