All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 10/10 v2] Document I2C_MPC option for 86xx too.
@ 2006-06-08 22:04 Jon Loeliger
  2006-06-09  7:37 ` Jean Delvare
  0 siblings, 1 reply; 3+ messages in thread
From: Jon Loeliger @ 2006-06-08 22:04 UTC (permalink / raw)
  To: linuxppc-dev@ozlabs.org, khali


Signed-off-by: Jon Loeliger <jdl@freescale.com>

---
 drivers/i2c/busses/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index d6d4494..fbeae82 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -252,12 +252,12 @@ config I2C_POWERMAC
 	  will be called i2c-powermac.
 
 config I2C_MPC
-	tristate "MPC107/824x/85xx/52xx"
+	tristate "MPC107/824x/85xx/52xx/86xx"
 	depends on I2C && PPC32
 	help
 	  If you say yes to this option, support will be included for the
 	  built-in I2C interface on the MPC107/Tsi107/MPC8240/MPC8245 and
-	  MPC85xx family processors. The driver may also work on 52xx
+	  MPC85xx/MPC8641 family processors. The driver may also work on 52xx
 	  family processors, though interrupts are known not to work.
 
 	  This driver can also be built as a module.  If so, the module

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 10/10 v2] Document I2C_MPC option for 86xx too.
  2006-06-08 22:04 [PATCH 10/10 v2] Document I2C_MPC option for 86xx too Jon Loeliger
@ 2006-06-09  7:37 ` Jean Delvare
  2006-06-09 13:50   ` Jon Loeliger
  0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2006-06-09  7:37 UTC (permalink / raw)
  To: Jon Loeliger; +Cc: linuxppc-dev

Hi Jon,

Please add a paragraph explaining what the patch does. It will be used
as the git commit message.

> Signed-off-by: Jon Loeliger <jdl@freescale.com>
> 
> ---
>  drivers/i2c/busses/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index d6d4494..fbeae82 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -252,12 +252,12 @@ config I2C_POWERMAC
>  	  will be called i2c-powermac.
>  
>  config I2C_MPC
> -	tristate "MPC107/824x/85xx/52xx"
> +	tristate "MPC107/824x/85xx/52xx/86xx"

Maybe leave 52xx at the end, as it seems to be special?

>  	depends on I2C && PPC32
>  	help
>  	  If you say yes to this option, support will be included for the
>  	  built-in I2C interface on the MPC107/Tsi107/MPC8240/MPC8245 and
> -	  MPC85xx family processors. The driver may also work on 52xx
> +	  MPC85xx/MPC8641 family processors. The driver may also work on 52xx
>  	  family processors, though interrupts are known not to work.
>  
>  	  This driver can also be built as a module.  If so, the module
> 

This isn't very consistent, you first say 86xx as if several chips were
supported, then only list the MPC8641. Also, "MPC85xx family" made
sense but "MPC8641 family" doesn't.

When fixed, do you expect me to take that patch, or will it be merged
through the powerpc git tree?

-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 10/10 v2] Document I2C_MPC option for 86xx too.
  2006-06-09  7:37 ` Jean Delvare
@ 2006-06-09 13:50   ` Jon Loeliger
  0 siblings, 0 replies; 3+ messages in thread
From: Jon Loeliger @ 2006-06-09 13:50 UTC (permalink / raw)
  To: Jean Delvare; +Cc: linuxppc-dev

So, like, the other day Jean Delvare mumbled:
> Hi Jon,
> 
> Please add a paragraph explaining what the patch does. It will be used
> as the git commit message.

Hi Jean,

There is a one-line commit message that will come from
the Subject: line.  If I add a paragraph, it will be

    "Document I2C_MPC option for 86xx too."

which will end up as a duplicate line in the commit message.

Thanks,
jdl

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-06-09 13:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-08 22:04 [PATCH 10/10 v2] Document I2C_MPC option for 86xx too Jon Loeliger
2006-06-09  7:37 ` Jean Delvare
2006-06-09 13:50   ` Jon Loeliger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.