All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@jdl.com>
To: Vitaly Bordug <vbordug@ru.mvista.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] POWERPC: mpc82xx merge: board-specific/platform stuff(resend)
Date: Fri, 22 Sep 2006 12:20:10 -0500	[thread overview]
Message-ID: <E1GQoh8-00055h-Av@jdl.com> (raw)
In-Reply-To: Your message of "Fri, 22 Sep 2006 17:50:57 +0400." <20060922135057.2859.29388.stgit@localhost.localdomain>

So, like, the other day Vitaly Bordug mumbled:
> 
> This intruduces 82xx family in arch/powerpc/platforms,
> and has all the board-specific code to represent regression-less
> transaction from ppc. The functionality is apparently the same, including
> PCI controller.
> 
> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>

Excellent!  Thanks!


> +++ b/arch/powerpc/platforms/82xx/mpc82xx_ads.c

> +/*
> + * Called very early, device-tree isn't unflattened
> + */
> +static int __init mpc82xx_ads_probe(void)
> +{
> +	/* We always match for now, eventually we should look at
> +	 * the flat dev tree to ensure this is the board we are
> +	 * supposed to run on
> +	 */
> +	return 1;
> +}

Please implement this routine fully.  Something down this line:

    {
        unsigned long root = of_get_flat_dt_root();

        if (of_flat_dt_is_compatible(root, "mpc82xx"))
            return 1;        /* Looks good */

        return 0;
    }


And with that, ACK me:

    Acked-by: Jon Loeliger <jdl@freescale.com>

Thanks,
jdl

      reply	other threads:[~2006-09-22 17:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-22 13:50 [PATCH] POWERPC: mpc82xx merge: board-specific/platform stuff(resend) Vitaly Bordug
2006-09-22 17:20 ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1GQoh8-00055h-Av@jdl.com \
    --to=jdl@jdl.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=vbordug@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.