From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Smolorz Subject: Re: [Xenomai-core] I-pipe patch for ARM S3C24xx Date: Mon, 30 Oct 2006 10:13:28 +0100 References: <454216BB.4090507@domain.hid> <45422A9C.5080505@domain.hid> In-Reply-To: <45422A9C.5080505@domain.hid> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: List-Id: "Xenomai life and development \(bug reports, patches, discussions\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gilles Chanteperdrix Cc: xenomai@xenomai.org Gilles Chanteperdrix wrote: > Gilles Chanteperdrix wrote: > > Sebastian Smolorz wrote: > >> Hi, > >> > >> here comes version 2 of the I-pipe patch for the S3C24xx ARM. The > >> reported problem is solved, the timer works as expected as far as I > >> can see. Linux is still there after insmod'ding the native skin. More > >> test results will follow next week after I tortured the new patch with > >> the whole testsuite arsenal. ;-) > >> > >> The patch has got two suboptimal characteristics due to the generic > >> ARM I-pipe implementation which I did not want to change during the > >> first steps: > >> > >> 1. Regarding the demux of chained IRQs (See [1]). As the S3C24xx has > >> more than one chained IRQ there are two consecutive queries for them > >> in __ipipe_mach_irq_mux_p() and __ipipe_mach_demux_irq(). This could > >> be optimized. > > > > You should use switch/case instead of if else if else if, the generated > > code would be better optimized. > > You can make the test cheap test by using a mask. Yes, I will do it that way. Thanks! Sebastian