All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amy Fong <amy.fong@windriver.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH] Add Broadcom PHY support
Date: Tue, 5 Dec 2006 00:55:16 -0500 (EST)	[thread overview]
Message-ID: <E1GrTGu-0005QS-OH@lucciola> (raw)
In-Reply-To: <1165266999.29784.20.camel@localhost.localdomain>

> On Fri, 2006-09-15 at 16:15 -0400, Amy Fong wrote:
> > [PATCH] Add Broadcom PHY support
> > 
> > This patch adds a driver to support the bcm5421s and bcm5461s PHY
> > 
> > Kernel version:  linux-2.6.18-rc6
> > 
> > Signed-off-by: Amy Fong 
> 
> Some 5421's need special initialisation (see drivers/net/sungem_phy.c),
> might be worth having them there too. I was also wondering... for
> spidernet, we need to enable the fiber mode on the PHY. Does phylib has
> an API for that ?
> 
> I'd like to look into moving sungem and spidernet over to phylib.
> 
> Ben.


I believe that this fiber enabling can be done by defining config_init in the phy_driver struct.

struct phy_driver {
<snip>
        /* Called to initialize the PHY,
	 * including after a reset */
	int (*config_init)(struct phy_device *phydev);
<snip>
};

ie.

static struct phy_driver bcm5421s_driver = {
<snip>
	.config_init = bcm5421s_phy_config,
<snip>
};

int bcm5421s_phy_config(struct phy_device *phydev)
{
...
	/* enable fiber mode here... */
...
}

Amy

  reply	other threads:[~2006-12-05  5:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-15 20:15 [PATCH] Add Broadcom PHY support Amy Fong
2006-09-19  4:39 ` Jeff Garzik
2006-09-19 13:35   ` Amy Fong
2006-09-19 13:43     ` Maciej W. Rozycki
2006-09-19 16:45       ` Jeff Garzik
2006-09-19 17:10         ` Maciej W. Rozycki
2006-12-04 21:16 ` Benjamin Herrenschmidt
2006-12-05  5:55   ` Amy Fong [this message]
2006-12-05  6:03     ` Benjamin Herrenschmidt
2006-12-05 19:50       ` Andy Fleming
  -- strict thread matches above, loose matches on Subject: below --
2006-09-15 19:28 Amy Fong
2006-09-15 20:05 ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1GrTGu-0005QS-OH@lucciola \
    --to=amy.fong@windriver.com \
    --cc=benh@kernel.crashing.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.