From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: David Gibson Subject: Re: [DTC PATCH] Add support for decimal, octal and binary based cell values. In-Reply-To: Your message of "Fri, 16 Feb 2007 09:19:07 +1100." <20070215221907.GC19126@localhost.localdomain> References: <20070215221907.GC19126@localhost.localdomain> Date: Thu, 15 Feb 2007 17:43:46 -0600 From: Jon Loeliger Message-Id: Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , So, like, the other day David Gibson mumbled: > > I'd prefer a different name for this - and possibly it should go in a > different file. The data_* prefix should be for functions that > actually manipulate struct data objects. ... > And I'd really prefer to keep the yyblah junk confined to the parser > code. I think it would be better to move this function into > dtc-parser.y OK. Yeah, that's sort of what I was alluding to with the "don't stress the yylval gunk". But OK, in any event I'll move this function to the parser file or so. > Otherwise looks pretty good. Thanks. jdl