All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@jdl.com>
To: Jerry Van Baren <gerald.vanbaren@comcast.net>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] DTC: Improve options handling - respin
Date: Mon, 19 Mar 2007 09:10:42 -0500	[thread overview]
Message-ID: <E1HTIZO-00036N-21@jdl.com> (raw)
In-Reply-To: Your message of "Sun, 18 Mar 2007 16:49:24 EDT." <45FDA5D4.7050004@comcast.net>

So, like, the other day Jerry Van Baren mumbled:
> 
> Hi David, Jon,
> 
> I was just seeing if I could get a rise out of you. It worked. ;-)
> 
> Attached is a respin of my previous two patches: it adds the -h and -q 
> options and #defines the default version but does _not_ delete the -R 
> option (left as an exercise for the reader to make it useful :-).

Please follow the patch layout guideline like this:

    Mail headers with
    From: <"default" author>
    Subject: <patch summary line>

    From: <actual author if different than mail envelope author>

    <detailed log message>

    <sign-off as needed>
    ---

    Notes and commentary

    <actual patch inline text>

As it was, manual patch editing was necessary to dodge
your introductory explanation.

> Subject: [PATCH] Improve options, #define default version.
> 
> Add -h option for help
> Add -q quiet option to reduce or suppress the whining
> Create #define for the default version value.
> 
> Signed-off-by: vanbaren@cideas.com <vanbaren@cideas.com>
> ---

Applied and pushed out!

However, two comments:

> ... but does _not_ delete the -R 
> option (left as an exercise for the reader to make it useful :-).

I'll certainly entertain a patch to fix the reserve space problem. :-)
That could have been my fault, though we both had our fingers in that pie.

> +	fprintf(stderr, "\t-q\n");
> +	fprintf(stderr, "\t\tQuiet: -q suppress warnings, -qq errors, -qqq all\n");

This is a bit misleading.  Sepcifically, -qqq does not currently
suppres "all" messagesm notably	those through yyerror().
An ambitious soul might beat me to fixing that up...


Thanks,
jdl

      reply	other threads:[~2007-03-19 14:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-17 17:03 [PATCH] DTC: Improve options handling Jerry Van Baren
2007-03-17 23:13 ` David Gibson
2007-03-18  0:35   ` Jerry Van Baren
2007-03-18  1:51     ` David Gibson
2007-03-18 20:49   ` [PATCH] DTC: Improve options handling - respin Jerry Van Baren
2007-03-19 14:10     ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1HTIZO-00036N-21@jdl.com \
    --to=jdl@jdl.com \
    --cc=gerald.vanbaren@comcast.net \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.