From: Jon Loeliger <jdl@jdl.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/4] DTC: Appease the printf() format $Gods with a correct type.
Date: Mon, 22 Oct 2007 11:50:52 -0500 [thread overview]
Message-ID: <E1Ik0UO-000389-AN@jdl.com> (raw)
In-Reply-To: Your message of "Sat, 20 Oct 2007 19:06:33 +1000." <20071020090633.GH26642@localhost.localdomain>
So, like, the other day David Gibson mumbled:
> On Sat, Oct 20, 2007 at 10:51:29AM +0200, Andreas Schwab wrote:
> > David Gibson <david@gibson.dropbear.id.au> writes:
> >
> > > What compiler/platform is this? I can't off the top of my head think
> > > of one where size_t shouldn't be promoted to int automatically.
> >
> > Only types narrower than int are subject to integer promotion.
>
> Duh, yes. Sorry.
So, Hmm. You want the patch as I wrote it applied?
Or do you want to use %z in the format instead? It does
seem like there is precedent to do that (in the kernel):
% grep -r '%z' arch/
arch/alpha/boot/tools/mkbb.c: fprintf(stderr, "expected %zd, got %d\n", sizeof(bootblock), nread);
arch/alpha/boot/tools/mkbb.c: fprintf(stderr, "expected %zd, got %d\n", sizeof(bootblock), nread);
arch/m68k/ifpsp060/src/itest.S: mulu.l (0x00.w,%a3,%za4.l*8),%d2:%d3
arch/m68k/ifpsp060/src/itest.S: mulu.l (-0x10.w,%za3,%a4.l*1),%d2:%d3
arch/m68k/ifpsp060/src/itest.S: mulu.l (ea_77_mem+0x00.w,%pc,%za4.l*8),%d2:%d3
...
arch/m68k/ifpsp060/src/itest.S: mulu.l ([EASTORE.l,%zpc,%zd4.l*1]),%d2:%d3
arch/m68k/ifpsp060/src/itest.S: mulu.l ([EASTORE.l,%pc],%zd4.l*8,0x20.l),%d2:%d3
arch/m68k/ifpsp060/src/itest.S: mulu.l ([EASTORE.l,%zpc],%d4.l*8),%d2:%d3
arch/um/drivers/cow_user.c: /* Below, %zd is for a size_t value */
arch/um/drivers/cow_user.c: "limited to %zd characters\n", backing_file,
arch/x86/kernel/pci-nommu_64.c: "nommu_%s: overflow %Lx+%zu of device mask %Lx\n",
Opinions?
Thanks,
jdl
next prev parent reply other threads:[~2007-10-22 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 17:43 [PATCH 3/4] DTC: Appease the printf() format $Gods with a correct type Jon Loeliger
2007-10-20 7:19 ` David Gibson
2007-10-20 8:51 ` Andreas Schwab
2007-10-20 9:06 ` David Gibson
2007-10-22 16:50 ` Jon Loeliger [this message]
2007-10-22 16:55 ` Josh Boyer
2007-10-23 0:26 ` David Gibson
2007-10-23 1:03 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Ik0UO-000389-AN@jdl.com \
--to=jdl@jdl.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.