All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@jdl.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: dtc: Don't force alignment of cell list data
Date: Mon, 05 Nov 2007 08:59:44 -0600	[thread overview]
Message-ID: <E1Ip3QW-0007lf-72@jdl.com> (raw)
In-Reply-To: Your message of "Fri, 02 Nov 2007 16:54:26 +1100." <20071102055426.GN19839@localhost.localdomain>

So, like, the other day David Gibson mumbled:
> At present, defining a property as, say:
> 	foo = [abcd], <ffffffff>;
> 
> Will cause dtc to insert 2 bytes of zeros between the abcd and the
> ffffffff, to align the cell form data.
> 
> Doing so seemed like a good idea at the time, but I don't believe
> there are any users who actually rely on this behaviour.  Segher
> claims that OF has some defined bindings which include properties an
> unaligned subsection of which is interpreted as 32-bit ints (i.e. like
> cell data).
> 
> Worse, this alignment will cause nothing but pain when we add
> expression support to dtc (when celldata is included in a larger
> bytestring expession, we won't know the size of the preceding chunk of
> the expression until it's evaluated, so we would have to carry
> alignment fixup information right through the expression evaluation
> process).
> 
> Therefore, this patch kills off this alignment behaviour.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Applied.

jdl

      reply	other threads:[~2007-11-05 14:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02  5:54 dtc: Don't force alignment of cell list data David Gibson
2007-11-05 14:59 ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Ip3QW-0007lf-72@jdl.com \
    --to=jdl@jdl.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.