From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from jdl.com (jdl.com [208.123.74.7]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 36AE5DDE35 for ; Thu, 14 Feb 2008 01:20:23 +1100 (EST) To: Kumar Gala Subject: Re: [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base In-Reply-To: Your message of "Wed, 13 Feb 2008 07:37:27 CST." References: Date: Wed, 13 Feb 2008 08:20:07 -0600 From: Jon Loeliger Message-Id: Cc: sparclinux@vger.kernel.org, linuxppc-dev@ozlabs.org, davem@davemloft.net, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , So, like, the other day Kumar Gala mumbled: > If we add to an empty lmb region with a non-zero base we will not coalesce > the number of regions done to one. This causes problems on ppc32 for the s/done/down > memory region as its assumed to only have one region. > > We can fix this be easily specially casing the initial add to just replace > the dummy region. > > --- > > Posting this since Dave's looking a pulling the lmb code out into lib/ and > sharing it between powerpc and sparc. Did you want to S-o-b: this patch? Or was this just informational? Thanks, jdl From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Date: Wed, 13 Feb 2008 14:20:07 +0000 Subject: Re: [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base Message-Id: List-Id: References: In-Reply-To: Your message of "Wed, 13 Feb 2008 07:37:27 CST." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kumar Gala Cc: sparclinux@vger.kernel.org, linuxppc-dev@ozlabs.org, davem@davemloft.net, linux-kernel@vger.kernel.org So, like, the other day Kumar Gala mumbled: > If we add to an empty lmb region with a non-zero base we will not coalesce > the number of regions done to one. This causes problems on ppc32 for the s/done/down > memory region as its assumed to only have one region. > > We can fix this be easily specially casing the initial add to just replace > the dummy region. > > --- > > Posting this since Dave's looking a pulling the lmb code out into lib/ and > sharing it between powerpc and sparc. Did you want to S-o-b: this patch? Or was this just informational? Thanks, jdl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758648AbYBMPAc (ORCPT ); Wed, 13 Feb 2008 10:00:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753750AbYBMPAX (ORCPT ); Wed, 13 Feb 2008 10:00:23 -0500 Received: from jdl.com ([208.123.74.7]:53732 "EHLO jdl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753023AbYBMPAW (ORCPT ); Wed, 13 Feb 2008 10:00:22 -0500 X-Greylist: delayed 2399 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Feb 2008 10:00:22 EST To: Kumar Gala cc: linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base In-Reply-To: Your message of "Wed, 13 Feb 2008 07:37:27 CST." References: Date: Wed, 13 Feb 2008 08:20:07 -0600 From: Jon Loeliger Message-Id: X-Spam-Score: -2.6 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org So, like, the other day Kumar Gala mumbled: > If we add to an empty lmb region with a non-zero base we will not coalesce > the number of regions done to one. This causes problems on ppc32 for the s/done/down > memory region as its assumed to only have one region. > > We can fix this be easily specially casing the initial add to just replace > the dummy region. > > --- > > Posting this since Dave's looking a pulling the lmb code out into lib/ and > sharing it between powerpc and sparc. Did you want to S-o-b: this patch? Or was this just informational? Thanks, jdl