All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@jdl.com>
To: git@vger.kernel.org
Subject: Dubious format-patch options
Date: Thu, 12 Jun 2008 20:14:17 -0500	[thread overview]
Message-ID: <E1K6xrt-00033S-2J@jdl.com> (raw)

Git-ites,

Hmmm... There are a ton of dubious options being accepted
by the "git format-patch" command due to it being a skinny
front to "git log".  Like, the -S and pick-axe crew:

Yeah, this is context-less, but my point is that we get
totally different behavior from the -S"string" here:

    $ git log -SC alt~1..HEAD
    commit bca87c386c8868664e64d397108b8e6deda1e574
    Author: Jon Loeliger <jdl@jdl.com>
    Date:   Thu Jun 12 17:57:57 2008 -0500

	C
versus

    $ git format-patch -SC alt~1..HEAD
    0001-C.patch
    0002-D.patch
    0003-Z.patch
    0004-F.patch

Oh yeah.

And --color is a cool thing too.  I mean, I was pleasantly
pleased with:

    $ git format-patch -1 --stdout --color master

But I seriously doubt that we _really_ want to send a
patch that has the embedded escape sequences in it:

    From: Jon Loeliger <jdl@jdl.com>
    Date: Thu, 12 Jun 2008 18:13:10 -0500
    Subject: [PATCH] F

    ---
     fileESC[m |    1 ESC[32m+ESC[m
     1 files changed, 1 insertions(+), 0 deletions(-)ESC[m

    ESC[1mdiff --git a/file b/fileESC[m
    ESC[1mindex 6ac15b9..65f21da 100644ESC[m
    ESC[1m--- a/fileESC[m
    ESC[1m+++ b/fileESC[m
    ESC[36m@@ -5,3 +5,4 @@ D
    ESC[m X
    ESC[m Y
    ESC[m Z
    ESC[mESC[32m+ESC[mESC[32mFESC[m
    -- 
    1.5.6.rc0.46.gd2b3

Oh yeah.  Another Vodka Tonic please while git-send-email that...

jdl

             reply	other threads:[~2008-06-13  1:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13  1:14 Jon Loeliger [this message]
2008-06-13  2:05 ` Dubious format-patch options Junio C Hamano
2008-06-13  2:24 ` Linus Torvalds
2008-06-13  3:01   ` Junio C Hamano
2008-06-13  6:33     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1K6xrt-00033S-2J@jdl.com \
    --to=jdl@jdl.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.