From: Jon Loeliger <jdl@jdl.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: dtc: Enable and fix -Wcast-qual warnings
Date: Mon, 14 Jul 2008 14:01:21 -0500 [thread overview]
Message-ID: <E1KITIX-0006ss-Be@jdl.com> (raw)
In-Reply-To: <20080707001415.GD6267@yookeroo.seuss>
> Enabling -Wcast-qual warnings in dtc shows up a number of places where
> we are incorrectly discarding a const qualification. There are also
> some places where we are intentionally discarding the 'const', and we
> need an ugly cast through uintptr_t to suppress the warning. However,
> most of these are pretty well isolated with the *_w() functions. So
> in the interests of maximum safety with const qualifications, this
> patch enables the warnings and fixes the existing complaints.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Guess which follow-on patch didn't apply for the same reason?
Needed to look like this hand-modified hunk...
> Index: dtc/Makefile
> ===================================================================
> --- dtc.orig/Makefile 2008-07-04 16:54:38.000000000 +1000
> +++ dtc/Makefile 2008-07-04 16:54:38.000000000 +1000
> @@ -16,7 +16,7 @@
> CONFIG_LOCALVERSION =
>
> CPPFLAGS = -I libfdt
> -CFLAGS = -Wall -g -Os -Wpointer-arith
> +CFLAGS = -Wall -g -Os -Wpointer-arith -Wcast-qual
>
> BISON = bison
> LEX = flex
Applied.
jdl
prev parent reply other threads:[~2008-07-14 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 0:14 dtc: Enable and fix -Wcast-qual warnings David Gibson
2008-07-14 19:01 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KITIX-0006ss-Be@jdl.com \
--to=jdl@jdl.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.