All of lore.kernel.org
 help / color / mirror / Atom feed
From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [5532] Replace uses of strndup (a GNU extension) with Qemu pstrdup
Date: Sat, 25 Oct 2008 11:23:27 +0000	[thread overview]
Message-ID: <E1KthEt-0006Tr-CT@cvs.savannah.gnu.org> (raw)

Revision: 5532
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5532
Author:   blueswir1
Date:     2008-10-25 11:23:27 +0000 (Sat, 25 Oct 2008)

Log Message:
-----------
Replace uses of strndup (a GNU extension) with Qemu pstrdup

Modified Paths:
--------------
    trunk/cutils.c
    trunk/hw/bt-hci.c
    trunk/qemu-common.h

Modified: trunk/cutils.c
===================================================================
--- trunk/cutils.c	2008-10-25 11:21:28 UTC (rev 5531)
+++ trunk/cutils.c	2008-10-25 11:23:27 UTC (rev 5532)
@@ -50,6 +50,18 @@
     return buf;
 }
 
+/* strdup with a limit */
+char *pstrdup(const char *str, size_t buf_size)
+{
+    size_t len;
+    char *buf;
+
+    len = MIN(buf_size, strlen(str));
+    buf = qemu_malloc(len);
+    pstrcpy(buf, len, str);
+    return buf;
+}
+
 int strstart(const char *str, const char *val, const char **ptr)
 {
     const char *p, *q;

Modified: trunk/hw/bt-hci.c
===================================================================
--- trunk/hw/bt-hci.c	2008-10-25 11:21:28 UTC (rev 5531)
+++ trunk/hw/bt-hci.c	2008-10-25 11:23:27 UTC (rev 5532)
@@ -1814,7 +1814,7 @@
 
         if (hci->device.lmp_name)
             free((void *) hci->device.lmp_name);
-        hci->device.lmp_name = strndup(PARAM(change_local_name, name),
+        hci->device.lmp_name = pstrdup(PARAM(change_local_name, name),
                         sizeof(PARAM(change_local_name, name)));
         bt_hci_event_complete_status(hci, HCI_SUCCESS);
         break;

Modified: trunk/qemu-common.h
===================================================================
--- trunk/qemu-common.h	2008-10-25 11:21:28 UTC (rev 5531)
+++ trunk/qemu-common.h	2008-10-25 11:23:27 UTC (rev 5532)
@@ -82,6 +82,7 @@
 /* cutils.c */
 void pstrcpy(char *buf, int buf_size, const char *str);
 char *pstrcat(char *buf, int buf_size, const char *s);
+char *pstrdup(const char *str, size_t buf_size);
 int strstart(const char *str, const char *val, const char **ptr);
 int stristart(const char *str, const char *val, const char **ptr);
 time_t mktimegm(struct tm *tm);

             reply	other threads:[~2008-10-25 11:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-25 11:23 Blue Swirl [this message]
2008-10-25 12:03 ` [Qemu-devel] [5532] Replace uses of strndup (a GNU extension) with Qemu pstrdup andrzej zaborowski
2008-10-25 12:18   ` Blue Swirl
2008-10-25 13:07     ` andrzej zaborowski
2008-10-25 13:49       ` Blue Swirl
2008-10-25 14:15         ` andrzej zaborowski
2008-10-25 14:31           ` Blue Swirl
2008-10-25 14:48             ` andrzej zaborowski
2008-10-26  9:00               ` Blue Swirl
2008-10-26 10:24                 ` andrzej zaborowski
2008-10-25 23:58   ` Warner Losh
2008-11-01 18:19 ` andrzej zaborowski
2008-11-01 18:31   ` Blue Swirl
2008-11-01 18:47     ` andrzej zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1KthEt-0006Tr-CT@cvs.savannah.gnu.org \
    --to=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.