From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MILQx-0006Q8-4g for mharc-grub-devel@gnu.org; Sun, 21 Jun 2009 07:42:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MILQv-0006OE-LS for grub-devel@gnu.org; Sun, 21 Jun 2009 07:42:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MILQt-0006Ml-1b for grub-devel@gnu.org; Sun, 21 Jun 2009 07:42:01 -0400 Received: from [199.232.76.173] (port=34298 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MILQs-0006Mi-ST for grub-devel@gnu.org; Sun, 21 Jun 2009 07:41:58 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:47133) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MILQs-0003qo-Iy for grub-devel@gnu.org; Sun, 21 Jun 2009 07:41:58 -0400 Received: from ams by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MILQs-000888-Db; Sun, 21 Jun 2009 07:41:58 -0400 From: "Alfred M. Szmidt" To: The development of GRUB 2 CC: grub-devel@gnu.org In-reply-to: <20090621112536.GF27710@thorin> (message from Robert Millan on Sun, 21 Jun 2009 13:25:36 +0200) References: <1245429440.28417.29.camel@mj> <20090621112536.GF27710@thorin> Message-Id: Date: Sun, 21 Jun 2009 07:41:58 -0400 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: Proposal for GNU indent compatibility X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jun 2009 11:42:01 -0000 > In order to encourage developers to use proper indentation on the > newly added code, I suggest that we accept the default style of > GNU indent. That is, the space after "!" should not be needed. > That's the only difference I'm aware of. What does GCS say about spaces after "!"? It doesn't say anything on the topic. But it has a single example relating to gnulib where there is a space used after !. | #include "error.h" | #include | #include | char *program_name = "myprogram"; | FILE * | xfopen (char const *name) | { | FILE *fp = fopen (name, "r"); | if (! fp) | error (1, errno, "cannot read %s", name); | return fp; | }