From: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: Lukasz Wojcik <zbr-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>,
devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: Use yylloc instead of yyloc
Date: Wed, 11 Nov 2009 21:42:59 -0600 [thread overview]
Message-ID: <E1N8QaJ-00031X-GU@jdl.com> (raw)
In-Reply-To: <20091112001404.GI3235-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
> Jon, fix for the typo the FreeBSD folks noticed. Please apply.
>
> yylloc is the correct way to get token positioning information. yyloc
> is a bison internal variable that only works by accident.
>
> Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
>
> Index: dtc/dtc-parser.y
> ===================================================================
> --- dtc.orig/dtc-parser.y 2009-11-12 11:11:15.000000000 +1100
> +++ dtc/dtc-parser.y 2009-11-12 11:11:20.000000000 +1100
> @@ -175,7 +175,7 @@ propdata:
>
> if ($6 != 0)
> if (fseek(file->file, $6, SEEK_SET) != 0)
> - srcpos_error(&yyloc,
> + srcpos_error(&yylloc,
> "Couldn't seek to offset %
> llu in \"%s\": %s",
> (unsigned long long)$6,
> $4.val,
>
>
Applied.
jdl
next parent reply other threads:[~2009-11-12 3:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091112001404.GI3235@yookeroo.seuss>
[not found] ` <20091112001404.GI3235-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2009-11-12 3:42 ` Jon Loeliger [this message]
[not found] ` <E1N8QaJ-00031X-GU-CYoMK+44s/E@public.gmane.org>
2009-11-13 13:10 ` Use yylloc instead of yyloc Lukasz Wojcik
[not found] ` <4AFD5AD6.6060906-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
2009-11-15 12:39 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1N8QaJ-00031X-GU@jdl.com \
--to=jdl-cyomk+44s/e@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=zbr-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.