From: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: Fix dtc bugs for 64-bit compile
Date: Wed, 11 Nov 2009 21:43:43 -0600 [thread overview]
Message-ID: <E1N8Qb1-00032G-4l@jdl.com> (raw)
In-Reply-To: <20091112023002.GN3235-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
> I've just tested building dtc as an x86_64 binary on a 32-bit i386
> host by using:
> make CC="gcc -m64"
> This patch fixes a handful of minor bugs thus discovered:
>
> * There is a printf() type mismatch on 64-bit in value-labels.c
>
> * For the tests which use libdl, we were using the GNU make feature
> where it will find libdl.so given a dependency in the form '-ldl'.
> But this built-in make logic doesn't know we're compiling 64-bit so
> finds the 32-bit version of the library. We avoid using this and
> instead explicitly pass -ldl to CC, which being the 64-bit version
> does know where to look.
>
> * To process dtc's asm output into .so files, run_tests.sh was
> directly invoking the (default instance of) the assembler and linker.
> Instead invoke these via the CC driver, and allow that to be overriden
> from the make environment.
>
> * The x86_64 assembler doesn't 0 fill with the .balign directive
> (presumably it is NOP filling). That doesn't produce strictly
> incorrect trees, but it is confusing and confounds are testcases which
> do byte-by-byte comparison of the trees produced by asm output with
> direct dtb output (which does 0 pad where necessary, of course). This
> patch uses the optional second argument to .balign to force gas to
> zero-fill instead.
>
> Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Applied.
jdl
prev parent reply other threads:[~2009-11-12 3:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 2:30 Fix dtc bugs for 64-bit compile David Gibson
[not found] ` <20091112023002.GN3235-787xzQ0H9iRg7VrjXcPTGA@public.gmane.org>
2009-11-12 3:43 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1N8Qb1-00032G-4l@jdl.com \
--to=jdl-cyomk+44s/e@public.gmane.org \
--cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.