From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Loeliger Subject: Re: [dtc] Remove another bashism from run_tests.sh Date: Mon, 20 Sep 2010 09:33:33 -0500 Message-ID: References: <20100830025303.GA5210@yookeroo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20100830025303.GA5210@yookeroo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: David Gibson Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org > Current we check for various error codes with [ $x == "NN" ]. However > '==' is not actually a correct operator for the [ (test) command. It > should be either '=' for string comparison or '-eq' for integer > comparison. It appears that the bash builtin version of test > implements '==' though, so we were getting away with it, as long as > /bin/sh was bash - or the testsuite generated no errors. > > This patch fixes the usage of test so that it should work on non-bash > shells. > > Signed-off-by: David Gibson Applied. Sorry for the delay. Thanks, jdl