All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: dtc: Add code to make diffing trees easier
Date: Mon, 11 Oct 2010 09:23:58 -0500	[thread overview]
Message-ID: <E1P5JIE-0002Pw-J1@jdl.com> (raw)
In-Reply-To: <20101011055219.GK23588-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>

> On Mon, Oct 11, 2010 at 11:37:38AM +1100, David Gibson wrote:
> > This patch adds a "dtdiff" script to do a useful form diff of two
> > device trees.  This automatically converts the tree to dts form (if
> > it's not already) and uses a new "-s" option in dtc to "sort" the
> > tree.  That is, it sorts the reserve entries, it sorts the properties
> > within each node by name, and it sorts nodes by name within their
> > parent.
> > 
> > This gives a pretty sensible diff between the trees, which will ignore
> > semantically null internal rearrangements (directly diffing the dts
> > files can give a lot of noise due to the order changes).
> > 
> > Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
> 
> Acked-by: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>

I am inclined to take this patch.  Any other comments?  Matt?

Thanks,
jdl

  parent reply	other threads:[~2010-10-11 14:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11  0:37 dtc: Add code to make diffing trees easier David Gibson
2010-10-11  5:52 ` Grant Likely
     [not found]   ` <20101011055219.GK23588-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-10-11 14:23     ` Jon Loeliger [this message]
     [not found]       ` <E1P5JIE-0002Pw-J1-CYoMK+44s/E@public.gmane.org>
2010-10-11 16:09         ` Matthew McClintock
2010-10-12  2:08         ` David Gibson
  -- strict thread matches above, loose matches on Subject: below --
2010-11-09 22:51 David Gibson
2010-11-10  0:02 ` John Bonesio
     [not found]   ` <4CD9E122.7040707-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
2010-11-10  0:55     ` David Gibson
2010-11-13 21:49 ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1P5JIE-0002Pw-J1@jdl.com \
    --to=jdl-cyomk+44s/e@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.